----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15995/#review29739 -----------------------------------------------------------
flume-ng-sinks/flume-ng-kafka-sink/src/main/java/org/apache/flume/sink/kafka/KafkaSink.java <https://reviews.apache.org/r/15995/#comment57200> Add class level comment with all exposed configuration. flume-ng-sinks/flume-ng-kafka-sink/src/main/java/org/apache/flume/sink/kafka/KafkaSink.java <https://reviews.apache.org/r/15995/#comment57197> Adding entry in SinkConfiguration is missing in this patch flume-ng-sinks/flume-ng-kafka-sink/src/main/java/org/apache/flume/sink/kafka/KafkaSink.java <https://reviews.apache.org/r/15995/#comment57206> 1> Add validation for topic, if it is mandatory configuration 2> Better to move all the kafka specific configuration constant to separate class flume-ng-sinks/flume-ng-kafka-sink/src/main/java/org/apache/flume/sink/kafka/KafkaSinkUtil.java <https://reviews.apache.org/r/15995/#comment57199> Can have single class called KafkaUtil for both Source and Sink to avoid few dupilcate code. flume-ng-sinks/flume-ng-kafka-sink/src/main/java/org/apache/flume/sink/kafka/KafkaSinkUtil.java <https://reviews.apache.org/r/15995/#comment57198> same log will be printed in getKafkaConfigProperties, can be removed either one place - Gopinathan Andavar On Dec. 4, 2013, 5:49 a.m., Frank Yao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15995/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2013, 5:49 a.m.) > > > Review request for Flume. > > > Repository: flume-git > > > Description > ------- > > Add Kafka(0.7.2) Source to flume-1.4, I'm using in our company for half year. > In my performance test, 100k message per second for 10 kafka sources is okay. > > > Diffs > ----- > > flume-ng-sinks/flume-ng-kafka-sink/pom.xml PRE-CREATION > > flume-ng-sinks/flume-ng-kafka-sink/src/main/java/org/apache/flume/sink/kafka/KafkaSink.java > PRE-CREATION > > flume-ng-sinks/flume-ng-kafka-sink/src/main/java/org/apache/flume/sink/kafka/KafkaSinkUtil.java > PRE-CREATION > > flume-ng-sinks/flume-ng-kafka-sink/src/test/java/org/apache/flume/sink/kafka/KafkaSinkTest.java > PRE-CREATION > > flume-ng-sinks/flume-ng-kafka-sink/src/test/java/org/apache/flume/sink/kafka/KafkaSinkUtilTest.java > PRE-CREATION > flume-ng-sinks/flume-ng-kafka-sink/src/test/resources/log4j.properties > PRE-CREATION > > Diff: https://reviews.apache.org/r/15995/diff/ > > > Testing > ------- > > Unitests are written whti JUnit and mockito. > > > Thanks, > > Frank Yao > >
