> On Dec. 4, 2013, 5:01 p.m., Gopinathan Andavar wrote: > > flume-ng-sinks/flume-ng-kafka-sink/src/main/java/org/apache/flume/sink/kafka/KafkaSinkUtil.java, > > line 29 > > <https://reviews.apache.org/r/15995/diff/1/?file=393841#file393841line29> > > > > Can have single class called KafkaUtil for both Source and Sink to > > avoid few dupilcate code.
kafka-source and kafka-sink is two different jar. Is is necessary to use one class to config? And how can I use one class for two jar? > On Dec. 4, 2013, 5:01 p.m., Gopinathan Andavar wrote: > > flume-ng-sinks/flume-ng-kafka-sink/src/main/java/org/apache/flume/sink/kafka/KafkaSink.java, > > line 61 > > <https://reviews.apache.org/r/15995/diff/1/?file=393840#file393840line61> > > > > 1> Add validation for topic, if it is mandatory configuration > > > > 2> Better to move all the kafka specific configuration constant to > > separate class I wrote kafka parameters in a separate class before and there are default values. But kafka has a lot of configuration and I think it is the users' responsibilities to consider which parameter to use. - Frank ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15995/#review29739 ----------------------------------------------------------- On Dec. 4, 2013, 5:49 a.m., Frank Yao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15995/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2013, 5:49 a.m.) > > > Review request for Flume. > > > Repository: flume-git > > > Description > ------- > > Add Kafka(0.7.2) Source to flume-1.4, I'm using in our company for half year. > In my performance test, 100k message per second for 10 kafka sources is okay. > > > Diffs > ----- > > flume-ng-sinks/flume-ng-kafka-sink/pom.xml PRE-CREATION > > flume-ng-sinks/flume-ng-kafka-sink/src/main/java/org/apache/flume/sink/kafka/KafkaSink.java > PRE-CREATION > > flume-ng-sinks/flume-ng-kafka-sink/src/main/java/org/apache/flume/sink/kafka/KafkaSinkUtil.java > PRE-CREATION > > flume-ng-sinks/flume-ng-kafka-sink/src/test/java/org/apache/flume/sink/kafka/KafkaSinkTest.java > PRE-CREATION > > flume-ng-sinks/flume-ng-kafka-sink/src/test/java/org/apache/flume/sink/kafka/KafkaSinkUtilTest.java > PRE-CREATION > flume-ng-sinks/flume-ng-kafka-sink/src/test/resources/log4j.properties > PRE-CREATION > > Diff: https://reviews.apache.org/r/15995/diff/ > > > Testing > ------- > > Unitests are written whti JUnit and mockito. > > > Thanks, > > Frank Yao > >
