> On Dec. 13, 2013, 3:32 a.m., Mike Percy wrote: > > flume-ng-core/src/test/java/org/apache/flume/source/TestSpoolDirectorySource.java, > > line 126 > > <https://reviews.apache.org/r/15899/diff/1/?file=392258#file392258line126> > > > > This is racy and on a slow build machine this test might spuriously > > fail once in a while. > > > > Let's just watch the SourceCounter for the expected # of events taken > > before continuing. > > > > Something like: > > > > while (source.getSourceCounter().getEventAcceptedCount() < > > numExpectedEvents) { > > Thread.sleep(10); > > }
What about using a CountDownLatch instead of sleep? - Bruno ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15899/#review30331 ----------------------------------------------------------- On Nov. 28, 2013, 2:15 a.m., Jeff jlord wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15899/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2013, 2:15 a.m.) > > > Review request for Flume, Hari Shreedharan and Mike Percy. > > > Repository: flume-git > > > Description > ------- > > Pretty simple patch which adds a boolean config basenameHeader to > SpoolDirSource. > This will allow for loading the basename of the file that the event was > created from in the headers. > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/client/avro/ReliableSpoolingFileEventReader.java > bd684ed > > flume-ng-core/src/main/java/org/apache/flume/source/SpoolDirectorySource.java > 72c4059 > > flume-ng-core/src/main/java/org/apache/flume/source/SpoolDirectorySourceConfigurationConstants.java > 7bfb0ee > > flume-ng-core/src/test/java/org/apache/flume/source/TestSpoolDirectorySource.java > 837cf15 > flume-ng-doc/sphinx/FlumeUserGuide.rst 0f12427 > > Diff: https://reviews.apache.org/r/15899/diff/ > > > Testing > ------- > > Added Unit Test. > > > Thanks, > > Jeff jlord > >
