----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15899/#review30419 -----------------------------------------------------------
Ship it! +1 LGTM. Please attach the patch to the JIRA. - Mike Percy On Dec. 14, 2013, 12:57 a.m., Jeff jlord wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15899/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2013, 12:57 a.m.) > > > Review request for Flume, Hari Shreedharan and Mike Percy. > > > Repository: flume-git > > > Description > ------- > > Pretty simple patch which adds a boolean config basenameHeader to > SpoolDirSource. > This will allow for loading the basename of the file that the event was > created from in the headers. > > > Diffs > ----- > > > flume-ng-core/src/main/java/org/apache/flume/client/avro/ReliableSpoolingFileEventReader.java > bd684ed > > flume-ng-core/src/main/java/org/apache/flume/source/SpoolDirectorySource.java > 0160215 > > flume-ng-core/src/main/java/org/apache/flume/source/SpoolDirectorySourceConfigurationConstants.java > a2befe8 > > flume-ng-core/src/test/java/org/apache/flume/source/TestSpoolDirectorySource.java > 9a546a5 > flume-ng-doc/sphinx/FlumeUserGuide.rst 335a991 > > Diff: https://reviews.apache.org/r/15899/diff/ > > > Testing > ------- > > Added Unit Test. > > > Thanks, > > Jeff jlord > >
