----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18544/#review51208 -----------------------------------------------------------
Hi, Thank you very mcuh Roshan! I have some comments. conf/log4j.properties <https://reviews.apache.org/r/18544/#comment89249> Hmm, are we doing this? flume-ng-doc/sphinx/FlumeUserGuide.rst <https://reviews.apache.org/r/18544/#comment89250> trailing ws flume-ng-legacy-sources/flume-thrift-source/src/test/java/org/apache/flume/source/thriftLegacy/TestThriftLegacySource.java <https://reviews.apache.org/r/18544/#comment89251> this isn't upgraded to 0.9.1 but if we did remove this we'd need to remove this comments flume-ng-sinks/flume-hive-sink/src/main/java/org/apache/flume/sink/hive/HiveDelimitedTextSerializer.java <https://reviews.apache.org/r/18544/#comment89252> why is this not private? also both of these will default to null flume-ng-sinks/flume-hive-sink/src/main/java/org/apache/flume/sink/hive/HiveDelimitedTextSerializer.java <https://reviews.apache.org/r/18544/#comment89253> let's put all these constants in a constant flume-ng-sinks/flume-hive-sink/src/main/java/org/apache/flume/sink/hive/HiveDelimitedTextSerializer.java <https://reviews.apache.org/r/18544/#comment89254> The rest of this file has many spacing mistakes flume-ng-sinks/flume-hive-sink/src/main/java/org/apache/flume/sink/hive/HiveSink.java <https://reviews.apache.org/r/18544/#comment89260> constants should be in ALL CAPS flume-ng-sinks/flume-hive-sink/src/main/java/org/apache/flume/sink/hive/HiveSink.java <https://reviews.apache.org/r/18544/#comment89261> why is this not private? flume-ng-sinks/flume-hive-sink/src/main/java/org/apache/flume/sink/hive/HiveSink.java <https://reviews.apache.org/r/18544/#comment89262> why is this visible? flume-ng-sinks/flume-hive-sink/src/main/java/org/apache/flume/sink/hive/HiveSink.java <https://reviews.apache.org/r/18544/#comment89263> pls move constants to a constants class flume-ng-sinks/flume-hive-sink/src/main/java/org/apache/flume/sink/hive/HiveSink.java <https://reviews.apache.org/r/18544/#comment89264> space on each side of == flume-ng-sinks/flume-hive-sink/src/main/java/org/apache/flume/sink/hive/HiveSink.java <https://reviews.apache.org/r/18544/#comment89265> more space issues (all over) this file flume-ng-sinks/flume-hive-sink/src/main/java/org/apache/flume/sink/hive/HiveSink.java <https://reviews.apache.org/r/18544/#comment89267> comemnted out code should be removed flume-ng-sinks/flume-hive-sink/src/main/java/org/apache/flume/sink/hive/HiveSink.java <https://reviews.apache.org/r/18544/#comment89270> more space issues flume-ng-sinks/flume-hive-sink/src/main/java/org/apache/flume/sink/hive/HiveSink.java <https://reviews.apache.org/r/18544/#comment89271> why are we doing a for loop on a single item? flume-ng-sinks/flume-hive-sink/src/main/java/org/apache/flume/sink/hive/HiveWriter.java <https://reviews.apache.org/r/18544/#comment89272> if cause is an Error it should be re-thrown as Error. flume-ng-sinks/flume-hive-sink/src/main/java/org/apache/flume/sink/hive/HiveWriter.java <https://reviews.apache.org/r/18544/#comment89273> remove commented out code flume-ng-sinks/flume-hive-sink/src/main/java/org/apache/flume/sink/hive/HiveWriter.java <https://reviews.apache.org/r/18544/#comment89274> nest exception flume-ng-sinks/flume-hive-sink/src/main/java/org/apache/flume/sink/hive/HiveWriter.java <https://reviews.apache.org/r/18544/#comment89269> all of these should end with Exception flume-ng-sinks/flume-hive-sink/src/test/java/org/apache/flume/sink/hive/TestUtil.java <https://reviews.apache.org/r/18544/#comment89275> commented code should be removed - Brock Noland On June 14, 2014, 4:19 a.m., Roshan Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18544/ > ----------------------------------------------------------- > > (Updated June 14, 2014, 4:19 a.m.) > > > Review request for Flume. > > > Bugs: FLUME-1734 > https://issues.apache.org/jira/browse/FLUME-1734 > > > Repository: flume-git > > > Description > ------- > > Hive streaming sink. > > > Diffs > ----- > > bin/flume-ng e09e26b > conf/log4j.properties 3918511 > > flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java > ac11558 > > flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java > 0a1cd7a > flume-ng-dist/pom.xml 690fec5 > flume-ng-doc/sphinx/FlumeUserGuide.rst b2058f5 > > flume-ng-legacy-sources/flume-thrift-source/src/main/java/com/cloudera/flume/handlers/thrift/ThriftFlumeEventServer.java > ff32c45 > > flume-ng-legacy-sources/flume-thrift-source/src/test/java/org/apache/flume/source/thriftLegacy/TestThriftLegacySource.java > 8e08f22 > > flume-ng-sdk/src/main/java/org/apache/flume/thrift/ThriftSourceProtocol.java > 7f966b0 > flume-ng-sinks/flume-hive-sink/pom.xml PRE-CREATION > > flume-ng-sinks/flume-hive-sink/src/main/java/org/apache/flume/sink/hive/HiveDelimitedTextSerializer.java > PRE-CREATION > > flume-ng-sinks/flume-hive-sink/src/main/java/org/apache/flume/sink/hive/HiveEventSerializer.java > PRE-CREATION > > flume-ng-sinks/flume-hive-sink/src/main/java/org/apache/flume/sink/hive/HiveJsonSerializer.java > PRE-CREATION > > flume-ng-sinks/flume-hive-sink/src/main/java/org/apache/flume/sink/hive/HiveSink.java > PRE-CREATION > > flume-ng-sinks/flume-hive-sink/src/main/java/org/apache/flume/sink/hive/HiveWriter.java > PRE-CREATION > > flume-ng-sinks/flume-hive-sink/src/test/java/org/apache/flume/sink/hive/TestHiveSink.java > PRE-CREATION > > flume-ng-sinks/flume-hive-sink/src/test/java/org/apache/flume/sink/hive/TestHiveWriter.java > PRE-CREATION > > flume-ng-sinks/flume-hive-sink/src/test/java/org/apache/flume/sink/hive/TestUtil.java > PRE-CREATION > flume-ng-sinks/flume-hive-sink/src/test/resources/log4j.properties > PRE-CREATION > flume-ng-sinks/pom.xml 56c4dee > > flume-ng-sources/flume-scribe-source/src/main/java/org/apache/flume/source/scribe/Scribe.java > eba8d2e > pom.xml 4dae2c9 > > Diff: https://reviews.apache.org/r/18544/diff/ > > > Testing > ------- > > This version lacks unit tests. > > > Thanks, > > Roshan Naik > >
