> On Oct. 14, 2014, 11:05 p.m., Brock Noland wrote: > > flume-ng-sinks/flume-hive-sink/src/test/java/org/apache/flume/sink/hive/TestUtil.java, > > line 136 > > <https://reviews.apache.org/r/18544/diff/5/?file=674780#file674780line136> > > > > We should log exceptions like this.
loogging not yet been added in for unit tests. this class is used for unit tests. > On Oct. 14, 2014, 11:05 p.m., Brock Noland wrote: > > flume-ng-legacy-sources/flume-thrift-source/src/main/java/com/cloudera/flume/handlers/thrift/ThriftFlumeEventServer.java, > > line 212 > > <https://reviews.apache.org/r/18544/diff/5/?file=674768#file674768line212> > > > > are these changes due to the rev in the thrift version? yes. my notes suggest a race condition in TThreadSeverPool - Roshan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18544/#review56592 ----------------------------------------------------------- On Sept. 3, 2014, 3:19 a.m., Roshan Naik wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18544/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2014, 3:19 a.m.) > > > Review request for Flume. > > > Bugs: FLUME-1734 > https://issues.apache.org/jira/browse/FLUME-1734 > > > Repository: flume-git > > > Description > ------- > > Hive streaming sink. > > > Diffs > ----- > > bin/flume-ng e09e26b > conf/log4j.properties 3918511 > > flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkConfiguration.java > ac11558 > > flume-ng-configuration/src/main/java/org/apache/flume/conf/sink/SinkType.java > 0a1cd7a > flume-ng-dist/pom.xml 8c18af6 > flume-ng-doc/sphinx/FlumeUserGuide.rst a718fbf > > flume-ng-legacy-sources/flume-thrift-source/src/main/java/com/cloudera/flume/handlers/thrift/ThriftFlumeEventServer.java > ff32c45 > > flume-ng-legacy-sources/flume-thrift-source/src/test/java/org/apache/flume/source/thriftLegacy/TestThriftLegacySource.java > 8e08f22 > > flume-ng-sdk/src/main/java/org/apache/flume/thrift/ThriftSourceProtocol.java > 7f966b0 > flume-ng-sinks/flume-hive-sink/pom.xml PRE-CREATION > > flume-ng-sinks/flume-hive-sink/src/main/java/org/apache/flume/sink/hive/Config.java > PRE-CREATION > > flume-ng-sinks/flume-hive-sink/src/main/java/org/apache/flume/sink/hive/HiveDelimitedTextSerializer.java > PRE-CREATION > > flume-ng-sinks/flume-hive-sink/src/main/java/org/apache/flume/sink/hive/HiveEventSerializer.java > PRE-CREATION > > flume-ng-sinks/flume-hive-sink/src/main/java/org/apache/flume/sink/hive/HiveJsonSerializer.java > PRE-CREATION > > flume-ng-sinks/flume-hive-sink/src/main/java/org/apache/flume/sink/hive/HiveSink.java > PRE-CREATION > > flume-ng-sinks/flume-hive-sink/src/main/java/org/apache/flume/sink/hive/HiveWriter.java > PRE-CREATION > > flume-ng-sinks/flume-hive-sink/src/test/java/org/apache/flume/sink/hive/TestHiveSink.java > PRE-CREATION > > flume-ng-sinks/flume-hive-sink/src/test/java/org/apache/flume/sink/hive/TestHiveWriter.java > PRE-CREATION > > flume-ng-sinks/flume-hive-sink/src/test/java/org/apache/flume/sink/hive/TestUtil.java > PRE-CREATION > flume-ng-sinks/flume-hive-sink/src/test/resources/log4j.properties > PRE-CREATION > flume-ng-sinks/pom.xml 3381bde > > flume-ng-sources/flume-scribe-source/src/main/java/org/apache/flume/source/scribe/Scribe.java > eba8d2e > pom.xml 4bdfcac > > Diff: https://reviews.apache.org/r/18544/diff/ > > > Testing > ------- > > includes unit tests. > > > Thanks, > > Roshan Naik > >
