----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31339/#review73974 -----------------------------------------------------------
Have you looked at Hbase sink, and Kite sink? They also have Kerberos login code - you'd have to refactor that as well. In general, it looks good. But I am really worried about pulling in hadoop and its dependencies. flume-ng-auth/pom.xml <https://reviews.apache.org/r/31339/#comment120384> Do we really need to add a dependency to hadoop-common? Can we just use hadoop-auth? I don't want to add hadoop as a dependency to flume-ng-sdk - that would be a major pain for users. Remember, flume-ng-sdk needs to be added to customer code. Adding hadoop-common will pull in a whole lot of dependencies. Is there a way to separate this out? flume-ng-auth/src/main/java/org/apache/flume/auth/KerberosAuthenticator.java <https://reviews.apache.org/r/31339/#comment120394> I don't think this is required. My understanding is that at least Hadoop does re-login automatically. Can you verify this is not the case in general? flume-ng-auth/src/main/java/org/apache/flume/auth/KerberosAuthenticator.java <https://reviews.apache.org/r/31339/#comment120396> Do you really want to relogin every 30 seconds? That is going to be put a lot of load on the KDC! - Hari Shreedharan On Feb. 24, 2015, 4:11 a.m., Johny Rufus John wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31339/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2015, 4:11 a.m.) > > > Review request for Flume. > > > Bugs: FLUME-2631 > https://issues.apache.org/jira/browse/FLUME-2631 > > > Repository: flume-git > > > Description > ------- > > End to End authentication in Flume > > > Diffs > ----- > > flume-ng-auth/pom.xml PRE-CREATION > > flume-ng-auth/src/main/java/org/apache/flume/auth/KerberosAuthenticator.java > PRE-CREATION > flume-ng-core/pom.xml 8992414 > flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java > 06bb604 > flume-ng-dist/pom.xml a083fe2 > flume-ng-dist/src/main/assembly/bin.xml 5aa7cc6 > flume-ng-dist/src/main/assembly/src.xml b1e79a2 > flume-ng-sdk/pom.xml 113b286 > flume-ng-sdk/src/main/java/org/apache/flume/api/ThriftRpcClient.java > 4f75a2b > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java > 33f73a9 > pom.xml ea7ffe3 > > Diff: https://reviews.apache.org/r/31339/diff/ > > > Testing > ------- > > Tested in kerberos cluster with combinations of Thrift Src, Sink and Hdfs Sink > > > Thanks, > > Johny Rufus John > >
