----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31339/#review75457 -----------------------------------------------------------
flume-ng-auth/src/main/java/org/apache/flume/api/SecureThriftRpcClient.java <https://reviews.apache.org/r/31339/#comment122508> This should be called client-principal and agent-principal right? flume-ng-auth/src/main/java/org/apache/flume/api/SecureThriftRpcClient.java <https://reviews.apache.org/r/31339/#comment122509> This can be return new UgiSasl... flume-ng-auth/src/main/java/org/apache/flume/api/SecureThriftRpcClient.java <https://reviews.apache.org/r/31339/#comment122510> Can't you do this: public Void run() throws FlumeException { super.open(); return null; } flume-ng-auth/src/main/java/org/apache/flume/auth/FlumeAuthenticator.java <https://reviews.apache.org/r/31339/#comment122512> Why does this method need to be exposed? This is required only in the KerberosAuthenticator, correct? Why can't it be used there alone? I think it is fair to document in the interface and in the UGI executor javadocs that the refresh thread will start up and periodically update the credentials. I don't see how it would be possible for a user to use this without calling this method anyway. We should rather do that for them, than force the user to renew. flume-ng-auth/src/main/java/org/apache/flume/auth/KerberosAuthenticator.java <https://reviews.apache.org/r/31339/#comment122513> This should be logged, not printed - Hari Shreedharan On March 6, 2015, 4:01 a.m., Johny Rufus John wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31339/ > ----------------------------------------------------------- > > (Updated March 6, 2015, 4:01 a.m.) > > > Review request for Flume. > > > Bugs: FLUME-2631 > https://issues.apache.org/jira/browse/FLUME-2631 > > > Repository: flume-git > > > Description > ------- > > End to End authentication in Flume > > > Diffs > ----- > > flume-ng-auth/pom.xml PRE-CREATION > > flume-ng-auth/src/main/java/org/apache/flume/api/SecureRpcClientFactory.java > PRE-CREATION > flume-ng-auth/src/main/java/org/apache/flume/api/SecureThriftRpcClient.java > PRE-CREATION > > flume-ng-auth/src/main/java/org/apache/flume/auth/FlumeAuthenticationUtil.java > PRE-CREATION > flume-ng-auth/src/main/java/org/apache/flume/auth/FlumeAuthenticator.java > PRE-CREATION > > flume-ng-auth/src/main/java/org/apache/flume/auth/KerberosAuthenticator.java > PRE-CREATION > flume-ng-auth/src/main/java/org/apache/flume/auth/PrivilegedExecutor.java > PRE-CREATION > flume-ng-auth/src/main/java/org/apache/flume/auth/SecurityException.java > PRE-CREATION > flume-ng-auth/src/main/java/org/apache/flume/auth/SimpleAuthenticator.java > PRE-CREATION > flume-ng-auth/src/main/java/org/apache/flume/auth/UGIExecutor.java > PRE-CREATION > > flume-ng-auth/src/test/java/org/apache/flume/auth/TestFlumeAuthenticator.java > PRE-CREATION > flume-ng-core/pom.xml 8992414 > flume-ng-core/src/main/java/org/apache/flume/sink/ThriftSink.java baa60d0 > flume-ng-core/src/main/java/org/apache/flume/source/ThriftSource.java > 06bb604 > flume-ng-dist/pom.xml a083fe2 > flume-ng-dist/src/main/assembly/bin.xml 5aa7cc6 > flume-ng-dist/src/main/assembly/src.xml b1e79a2 > > flume-ng-sdk/src/main/java/org/apache/flume/api/RpcClientConfigurationConstants.java > 33a2330 > flume-ng-sdk/src/main/java/org/apache/flume/api/ThriftRpcClient.java > 4f75a2b > flume-ng-sinks/flume-dataset-sink/pom.xml e929d60 > > flume-ng-sinks/flume-dataset-sink/src/main/java/org/apache/flume/sink/kite/DatasetSink.java > 3e66532 > > flume-ng-sinks/flume-dataset-sink/src/main/java/org/apache/flume/sink/kite/KerberosUtil.java > c0dbffb > > flume-ng-sinks/flume-dataset-sink/src/test/java/org/apache/flume/sink/kite/TestKerberosUtil.java > f53ef73 > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/BucketWriter.java > 62f4eee > > flume-ng-sinks/flume-hdfs-sink/src/main/java/org/apache/flume/sink/hdfs/HDFSEventSink.java > 33f73a9 > > flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestBucketWriter.java > 7c74b16 > > flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSink.java > 1b7a364 > > flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSink.java > 5de0bd5 > > flume-ng-sinks/flume-ng-hbase-sink/src/main/java/org/apache/flume/sink/hbase/HBaseSinkSecurityManager.java > 762fce9 > pom.xml ea7ffe3 > > Diff: https://reviews.apache.org/r/31339/diff/ > > > Testing > ------- > > Tested in kerberos cluster with combinations of Thrift Src, Sink and Hdfs Sink > > > Thanks, > > Johny Rufus John > >
