[ 
https://issues.apache.org/jira/browse/FLUME-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15062923#comment-15062923
 ] 

Pushkar Raste commented on FLUME-2856:
--------------------------------------

I have a patch, however to support *maxHistory* feature (i.e. to delete older 
files) I had to be able to predict file names. I introduced new required 
property for {{RollingFileSink}} called *fileName*. This is the only backwards 
incompatible change from end users point of view. I have also made a couple of 
backwards incompatible changes to {{PathManager}} class. However 
{{PathManager}} class is not being used by any class other than 
{{RollingFileSink}} class. 

I am open to rewrite some of the changes if people think refactoring will cause 
any issues. I would also like to know if there is any standard procedure to 
submit the patch.

> Adding size based rolling support and ability to delete old files for 
> RollingFileSink
> -------------------------------------------------------------------------------------
>
>                 Key: FLUME-2856
>                 URL: https://issues.apache.org/jira/browse/FLUME-2856
>             Project: Flume
>          Issue Type: Improvement
>            Reporter: Pushkar Raste
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> {{RollingFileSink}} provides ability only to roll files on a fixed schedule. 
> Add ability to roll file after it reaches a certain size. 
> It would also be great to delete old files



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to