[ 
https://issues.apache.org/jira/browse/FLUME-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15106702#comment-15106702
 ] 

ASF GitHub Bot commented on FLUME-2856:
---------------------------------------

GitHub user praste opened a pull request:

    https://github.com/apache/flume/pull/32

    Size based rolling support for file sink

    This fixes #FLUME-2856.
    Also added support use a fixed naming pattern for files.
    Support for allowing to delete old sink files is also added.
    
    Updated documentation for above mentioned changes.
    
    
     To support `maxHistory` feature (i.e. to delete older files) I had to be 
able to predict file names. I introduced new required property for 
`RollingFileSink` called `fileName`. This is the only backwards incompatible 
change from end users point of view. I have also made a couple of backwards 
incompatible changes to `PathManager` class. However `PathManager` class is not 
being used by any class other than `RollingFileSink` class.
    
    I am open to rewrite some of the changes if people think refactoring will 
cause any issues.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/praste/flume trunk

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flume/pull/32.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #32
    
----
commit 9833bfd204512f964f18d3be50b557938b8620dd
Author: Pushkar Raste <[email protected]>
Date:   2016-01-19T13:24:06Z

    Size based rolling support for file sink
    This fixes #FLUME-2856.
    Also added support use a fixed naming pattern for files.
    Support for allowing to delete old sink files is also added.
    
    Updated documentation for above mentioned changes

----


> Adding size based rolling support and ability to delete old files for 
> RollingFileSink
> -------------------------------------------------------------------------------------
>
>                 Key: FLUME-2856
>                 URL: https://issues.apache.org/jira/browse/FLUME-2856
>             Project: Flume
>          Issue Type: Improvement
>    Affects Versions: v1.5.2
>            Reporter: Pushkar Raste
>              Labels: patch
>             Fix For: notrack
>
>         Attachments: 0001-Flume-archive-with-enhanced-file-sink.patch
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> {{RollingFileSink}} provides ability only to roll files on a fixed schedule. 
> Add ability to roll file after it reaches a certain size. 
> It would also be great to delete old files



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to