> On June 30, 2016, 6:48 p.m., Mike Percy wrote: > > pom.xml, line 872 > > <https://reviews.apache.org/r/49458/diff/1/?file=1434304#file1434304line872> > > > > Is this really the minimum Guava version required? Flume has to work > > with Hadoop and a lot of other components so this huge version jump scares > > me. > > Lior Zeno wrote: > The minimum Guava version requires is 18.0, due to > MoreExecutors.directExecutor. In the next elasticsearch release, Guava won't > be a dependency anymore. > Also, I will submit a new patch guava 18 and a newer diff due to the > latest commits. > > Lior Zeno wrote: > I shaded guava in flume-ng-elasticsearch-sink. I agree that bumping > guava's version is problematic, we might need to consider removing this > dependency now that we are working with java 1.7.
Great, thanks for doing that. I won't be around for several days due to the July 4 holiday. Maybe another dev has time to take a pass at this review in the meantime. - Mike ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49458/#review140215 ----------------------------------------------------------- On July 1, 2016, 2:40 p.m., Lior Zeno wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49458/ > ----------------------------------------------------------- > > (Updated July 1, 2016, 2:40 p.m.) > > > Review request for Flume. > > > Bugs: FLUME-2921 > https://issues.apache.org/jira/browse/FLUME-2921 > > > Repository: flume-git > > > Description > ------- > > This patch adds the support for Elasticsearch version 2.0+. The version I > used is 2.3.3, which is the latest stable release. This also required > upgrading guava. > This patch does not fix any known issues with this sink, its only purpose is > to support current versions of elasticsearch. > > > Diffs > ----- > > flume-ng-channels/flume-spillable-memory-channel/pom.xml 60e49d2 > flume-ng-core/pom.xml 41586dd > flume-ng-sinks/flume-ng-elasticsearch-sink/pom.xml c372c0b > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ContentBuilderUtil.java > 83c3ffd > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchLogStashEventSerializer.java > 3638368 > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/client/ElasticSearchTransportClient.java > 2cf365e > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/AbstractElasticSearchSinkTest.java > f9272fa > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchDynamicSerializer.java > d4e4654 > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchIndexRequestBuilderFactory.java > 8022111 > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchLogStashEventSerializer.java > ab9587d > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchSink.java > a58f344 > pom.xml 85c0dc8 > > Diff: https://reviews.apache.org/r/49458/diff/ > > > Testing > ------- > > I made sure that all unit tests (due to guava upgrade) pass successfully. The > known flaky tests may not pass, though. > > > Thanks, > > Lior Zeno > >
