> On July 1, 2016, 3:39 p.m., Attila Simon wrote: > > flume-ng-channels/flume-spillable-memory-channel/pom.xml, lines 81-85 > > <https://reviews.apache.org/r/49458/diff/3/?file=1434932#file1434932line81> > > > > is this change related to elastic search?
Sorry, this is a left-over from the first patch. > On July 1, 2016, 3:39 p.m., Attila Simon wrote: > > flume-ng-sinks/flume-ng-elasticsearch-sink/pom.xml, line 13 > > <https://reviews.apache.org/r/49458/diff/3/?file=1434934#file1434934line13> > > > > nit: changed indention (what is the guideline for pom.xml?) Fixed, intellij's refactoring changed that. > On July 1, 2016, 3:39 p.m., Attila Simon wrote: > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/client/ElasticSearchTransportClient.java, > > lines 143-147 > > <https://reviews.apache.org/r/49458/diff/3/?file=1434937#file1434937line143> > > > > serverAddresses[i] won't be initialized if host[i] was not found. > > wouldn't be better not keeping that entry from the returned array? Good catch, thanks. > On July 1, 2016, 3:39 p.m., Attila Simon wrote: > > pom.xml, lines 874-879 > > <https://reviews.apache.org/r/49458/diff/3/?file=1434943#file1434943line874> > > > > is this change related to elastic search? Same as above. On July 1, 2016, 3:39 p.m., Lior Zeno wrote: > > After applying the this diff on trunk I got <b>build failure</b> > > mvn clean install -DskipTests > > creates > > flume-ng-sinks/flume-ng-elasticsearch-sink/dependency-reduced-pom.xml which > > is then correctly caught by RAT check. Where is this file coming from? > > Should it be added to an ignore list? > > > > mvn -pl flume-ng-sinks/flume-ng-elasticsearch-sink/ test ===> passes This file is automatically generated by maven-shade-plugin. I disabled that using the createDependencyReducedPom configuration key. - Lior ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49458/#review140360 ----------------------------------------------------------- On July 1, 2016, 2:40 p.m., Lior Zeno wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49458/ > ----------------------------------------------------------- > > (Updated July 1, 2016, 2:40 p.m.) > > > Review request for Flume. > > > Bugs: FLUME-2921 > https://issues.apache.org/jira/browse/FLUME-2921 > > > Repository: flume-git > > > Description > ------- > > This patch adds the support for Elasticsearch version 2.0+. The version I > used is 2.3.3, which is the latest stable release. This also required > upgrading guava. > This patch does not fix any known issues with this sink, its only purpose is > to support current versions of elasticsearch. > > > Diffs > ----- > > flume-ng-channels/flume-spillable-memory-channel/pom.xml 60e49d2 > flume-ng-core/pom.xml 41586dd > flume-ng-sinks/flume-ng-elasticsearch-sink/pom.xml c372c0b > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ContentBuilderUtil.java > 83c3ffd > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/ElasticSearchLogStashEventSerializer.java > 3638368 > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/main/java/org/apache/flume/sink/elasticsearch/client/ElasticSearchTransportClient.java > 2cf365e > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/AbstractElasticSearchSinkTest.java > f9272fa > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchDynamicSerializer.java > d4e4654 > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchIndexRequestBuilderFactory.java > 8022111 > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchLogStashEventSerializer.java > ab9587d > > flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchSink.java > a58f344 > pom.xml 85c0dc8 > > Diff: https://reviews.apache.org/r/49458/diff/ > > > Testing > ------- > > I made sure that all unit tests (due to guava upgrade) pass successfully. The > known flaky tests may not pass, though. > > > Thanks, > > Lior Zeno > >
