[
https://issues.apache.org/jira/browse/FLUME-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15368629#comment-15368629
]
ASF subversion and git services commented on FLUME-2941:
--------------------------------------------------------
Commit cfbf1156858af9ae26975fefc94594d91c8cd3f4 in flume's branch
refs/heads/trunk from [~mpercy]
[ https://git-wip-us.apache.org/repos/asf?p=flume.git;h=cfbf115 ]
FLUME-2941. Integrate checkstyle for test classes
Also make test code conform to style guidelines.
Additionally, this patch makes style violations fatal to the build.
This patch is whitespace-only from a code perspective. After stripping
line numbers, the generated test bytecode before and after these changes
is identical.
Code review: https://reviews.apache.org/r/49830/
Reviewed by Hari.
> Integrate checkstyle for test classes
> -------------------------------------
>
> Key: FLUME-2941
> URL: https://issues.apache.org/jira/browse/FLUME-2941
> Project: Flume
> Issue Type: Improvement
> Reporter: Lior Zeno
> Assignee: Mike Percy
> Priority: Minor
> Fix For: v1.7.0
>
>
> We should add the maven-checkstyle-plugin to the build process. This plugin
> can fail a build if the code does not honor the style of our project. This
> way we can make sure that we have one common style in the code. In addition,
> reviewers can focus on design, correctness, performance and other important
> coding aspects other than style issues.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
