[
https://issues.apache.org/jira/browse/FLUME-2941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15368809#comment-15368809
]
Hudson commented on FLUME-2941:
-------------------------------
FAILURE: Integrated in Flume-trunk-hbase-1 #172 (See
[https://builds.apache.org/job/Flume-trunk-hbase-1/172/])
FLUME-2941. Integrate checkstyle for test classes (mpercy:
[http://git-wip-us.apache.org/repos/asf/flume/repo?p=flume.git&a=commit&h=cfbf1156858af9ae26975fefc94594d91c8cd3f4])
* flume-ng-sdk/src/test/java/org/apache/flume/api/RpcTestUtils.java
*
flume-ng-core/src/test/java/org/apache/flume/channel/TestMemoryChannelConcurrency.java
*
flume-ng-core/src/test/java/org/apache/flume/serialization/TestDurablePositionTracker.java
*
flume-ng-core/src/test/java/org/apache/flume/channel/TestMemoryChannelTransaction.java
*
flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestHDFSEventSink.java
* flume-checkstyle/src/main/resources/flume/checkstyle.xml
*
flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/client/RoundRobinListTest.java
*
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/CountingSinkRunner.java
*
flume-ng-sources/flume-kafka-source/src/test/java/org/apache/flume/source/kafka/TestKafkaSource.java
*
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/encryption/CipherProviderTestSuite.java
* flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUtils.java
*
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestEventQueueBackingStoreFactory.java
*
flume-tools/src/test/java/org/apache/flume/tools/TestFileChannelIntegrityTool.java
*
flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchLogStashEventSerializer.java
*
flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/TestDerbySchemaHandlerQueries.java
* flume-ng-auth/src/test/java/org/apache/flume/auth/TestFlumeAuthenticator.java
*
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/encryption/TestAESCTRNoPaddingProvider.java
* flume-ng-core/src/test/java/org/apache/flume/channel/TestChannelProcessor.java
* flume-ng-core/src/test/java/org/apache/flume/source/TestExecSource.java
*
flume-ng-sinks/flume-ng-kafka-sink/src/test/java/org/apache/flume/sink/kafka/util/ZooKeeperLocal.java
*
flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgent.java
* flume-ng-sdk/src/test/java/org/apache/flume/api/TestNettyAvroRpcClient.java
*
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRestart.java
*
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/encryption/TestJCEFileKeyProvider.java
*
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestUtils.java
*
flume-ng-sdk/src/test/java/org/apache/flume/api/TestLoadBalancingRpcClient.java
*
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelRollback.java
*
flume-ng-core/src/test/java/org/apache/flume/interceptor/TestRegexExtractorInterceptorPassThroughSerializer.java
*
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannelFormatRegression.java
* flume-ng-core/src/test/java/org/apache/flume/tools/TestVersionInfo.java
*
flume-ng-node/src/test/java/org/apache/flume/node/TestPropertiesFileConfigurationProvider.java
*
flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchSink.java
*
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/encryption/TestFileChannelEncryption.java
*
flume-ng-node/src/test/java/org/apache/flume/node/TestAbstractZooKeeperConfigurationProvider.java
*
flume-ng-channels/flume-spillable-memory-channel/src/test/java/org/apache/flume/channel/TestSpillableMemoryChannel.java
*
flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirEventReader.java
*
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestIntegration.java
* flume-ng-tests/src/test/java/org/apache/flume/test/agent/TestFileChannel.java
*
flume-ng-core/src/test/java/org/apache/flume/serialization/TestFlumeEventAvroEventSerializer.java
*
flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/MockEventUtils.java
*
flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/MockDataStream.java
*
flume-ng-core/src/test/java/org/apache/flume/formatter/output/TestBucketPath.java
*
flume-ng-sinks/flume-hive-sink/src/test/java/org/apache/flume/sink/hive/TestUtil.java
* flume-ng-sdk/src/test/java/org/apache/flume/api/TestThriftRpcClient.java
*
flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentConfiguration.java
*
flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/client/TestElasticSearchRestClient.java
*
flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchSinkCreation.java
*
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFileChannel.java
* flume-ng-sdk/src/test/java/org/apache/flume/api/ThriftTestingSource.java
*
flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/HDFSTestSeqWriter.java
*
flume-ng-legacy-sources/flume-thrift-source/src/test/java/org/apache/flume/source/thriftLegacy/TestThriftLegacySource.java
*
flume-ng-sinks/flume-ng-kafka-sink/src/test/java/org/apache/flume/sink/kafka/util/KafkaLocal.java
*
flume-ng-core/src/test/java/org/apache/flume/source/TestSpoolDirectorySource.java
*
flume-ng-core/src/test/java/org/apache/flume/tools/TestTimestampRoundDownUtil.java
*
flume-ng-legacy-sources/flume-avro-source/src/test/java/org/apache/flume/source/avroLegacy/TestLegacyAvroSource.java
*
flume-ng-sources/flume-jms-source/src/test/java/org/apache/flume/source/jms/JMSMessageConsumerTestBase.java
*
flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/TestElasticSearchIndexRequestBuilderFactory.java
*
flume-ng-sources/flume-kafka-source/src/test/java/org/apache/flume/source/kafka/KafkaSourceEmbeddedZookeeper.java
*
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestLog.java
* flume-ng-core/src/test/java/org/apache/flume/sink/TestRollingFileSink.java
*
flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentEmbeddedSource.java
*
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestCheckpoint.java
*
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/encryption/EncryptionTestUtils.java
*
flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestBucketWriter.java
*
flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLog4jAppender.java
*
flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/client/TestElasticSearchClientFactory.java
*
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestTransactionEventRecordV3.java
*
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestEventUtils.java
*
flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/MockEvent.java
*
flume-ng-core/src/test/java/org/apache/flume/instrumentation/TestMonitoredCounterGroup.java
*
flume-ng-embedded-agent/src/test/java/org/apache/flume/agent/embedded/TestEmbeddedAgentState.java
*
flume-ng-core/src/test/java/org/apache/flume/interceptor/TestRegexExtractorInterceptorMillisSerializer.java
* flume-checkstyle/src/main/resources/flume/checkstyle-suppressions.xml
*
flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/TestHBaseSink.java
* flume-ng-tests/src/test/java/org/apache/flume/test/util/StagedInstall.java
* flume-ng-core/src/test/java/org/apache/flume/sink/TestAvroSink.java
*
flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/TestAsyncHBaseSink.java
* flume-ng-core/src/test/java/org/apache/flume/sink/TestDefaultSinkFactory.java
*
flume-ng-sources/flume-jms-source/src/test/java/org/apache/flume/source/jms/TestJMSSource.java
*
flume-ng-core/src/test/java/org/apache/flume/sink/TestFailoverSinkProcessor.java
* flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogTcpSource.java
*
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/CountingSourceRunner.java
* flume-ng-core/src/test/java/org/apache/flume/source/http/TestHTTPSource.java
*
flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirSource.java
*
flume-ng-core/src/test/java/org/apache/flume/serialization/TestAvroEventDeserializer.java
* flume-ng-sdk/src/test/java/org/apache/flume/api/TestFailoverRpcClient.java
*
flume-ng-core/src/test/java/org/apache/flume/client/avro/TestReliableSpoolingFileEventReader.java
*
flume-ng-core/src/test/java/org/apache/flume/serialization/TestResettableFileInputStream.java
*
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/java/org/apache/flume/sink/solr/morphline/TestBlobDeserializer.java
* flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogParser.java
* flume-ng-core/src/test/java/org/apache/flume/source/TestThriftSource.java
*
flume-ng-core/src/test/java/org/apache/flume/source/http/FlumeHttpServletRequestWrapper.java
*
flume-ng-channels/flume-kafka-channel/src/test/java/org/apache/flume/channel/kafka/TestKafkaChannel.java
* flume-ng-core/src/test/java/org/apache/flume/source/TestSyslogUdpSource.java
*
flume-ng-sources/flume-kafka-source/src/test/java/org/apache/flume/source/kafka/KafkaSourceEmbeddedKafka.java
*
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/java/org/apache/flume/sink/solr/morphline/TestMorphlineSolrSink.java
*
flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLog4jAppenderWithAvro.java
*
flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/TestRegexHbaseEventSerializer.java
*
flume-ng-sinks/flume-irc-sink/src/test/java/org/apache/flume/sink/irc/TestIRCSink.java
*
flume-ng-core/src/test/java/org/apache/flume/source/TestSequenceGeneratorSource.java
* flume-ng-core/src/test/java/org/apache/flume/channel/TestMemoryChannel.java
*
flume-ng-core/src/test/java/org/apache/flume/sink/TestLoadBalancingSinkProcessor.java
*
flume-ng-sources/flume-jms-source/src/test/java/org/apache/flume/source/jms/TestIntegrationActiveMQ.java
* flume-ng-node/src/test/java/org/apache/flume/source/TestNetcatSource.java
*
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestLogFile.java
*
flume-ng-core/src/test/java/org/apache/flume/channel/AbstractBasicChannelSemanticsTest.java
*
flume-ng-core/src/test/java/org/apache/flume/serialization/TestSyslogAvroEventSerializer.java
*
flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/TestSequenceFileSerializerFactory.java
*
flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/MockFileSystem.java
* flume-ng-core/src/test/java/org/apache/flume/source/TestStressSource.java
*
flume-ng-channels/flume-jdbc-channel/src/test/java/org/apache/flume/channel/jdbc/BaseJdbcChannelProviderTest.java
* flume-ng-node/src/test/java/org/apache/flume/node/TestApplication.java
* flume-ng-tests/src/test/java/org/apache/flume/test/util/SyslogAgent.java
* flume-ng-core/src/test/java/org/apache/flume/source/TestAvroSource.java
* flume-ng-core/src/test/java/org/apache/flume/source/TestNetcatSource.java
*
flume-ng-sinks/flume-ng-elasticsearch-sink/src/test/java/org/apache/flume/sink/elasticsearch/AbstractElasticSearchSinkTest.java
*
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestFlumeEventQueue.java
*
flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/java/org/apache/flume/sink/solr/morphline/TestMorphlineInterceptor.java
*
flume-ng-core/src/test/java/org/apache/flume/serialization/SyslogAvroEventSerializer.java
*
flume-ng-sinks/flume-ng-kafka-sink/src/test/java/org/apache/flume/sink/kafka/TestKafkaSink.java
*
flume-ng-sinks/flume-hive-sink/src/test/java/org/apache/flume/sink/hive/TestHiveWriter.java
*
flume-ng-core/src/test/java/org/apache/flume/interceptor/TestSearchAndReplaceInterceptor.java
* flume-ng-core/src/test/java/org/apache/flume/sink/TestThriftSink.java
*
flume-ng-node/src/test/java/org/apache/flume/node/TestAbstractConfigurationProvider.java
* flume-checkstyle/pom.xml
*
flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/MockFsDataOutputStream.java
*
flume-ng-sources/flume-jms-source/src/test/java/org/apache/flume/source/jms/TestJMSMessageConsumer.java
*
flume-ng-node/src/test/java/org/apache/flume/node/TestPollingPropertiesFileConfigurationProvider.java
*
flume-ng-sinks/flume-hdfs-sink/src/test/java/org/apache/flume/sink/hdfs/MockHDFSWriter.java
*
flume-ng-sources/flume-jms-source/src/test/java/org/apache/flume/source/jms/TestDefaultJMSMessageConverter.java
*
flume-ng-sinks/flume-hive-sink/src/test/java/org/apache/flume/sink/hive/TestHiveSink.java
*
flume-ng-clients/flume-ng-log4jappender/src/test/java/org/apache/flume/clients/log4jappender/TestLoadBalancingLog4jAppender.java
*
flume-ng-channels/flume-file-channel/src/test/java/org/apache/flume/channel/file/TestTransactionEventRecordV2.java
*
flume-ng-core/src/test/java/org/apache/flume/source/TestMultiportSyslogTCPSource.java
*
flume-ng-core/src/test/java/org/apache/flume/source/TestAbstractPollableSource.java
*
flume-ng-sinks/flume-ng-hbase-sink/src/test/java/org/apache/flume/sink/hbase/IncrementAsyncHBaseSerializer.java
*
flume-ng-core/src/test/java/org/apache/flume/instrumentation/kafka/KafkaSourceCounterTest.java
*
flume-ng-core/src/test/java/org/apache/flume/instrumentation/http/TestHTTPMetricsServer.java
*
flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirMatcher.java
*
flume-ng-sinks/flume-dataset-sink/src/test/java/org/apache/flume/sink/kite/TestDatasetSink.java
* pom.xml
> Integrate checkstyle for test classes
> -------------------------------------
>
> Key: FLUME-2941
> URL: https://issues.apache.org/jira/browse/FLUME-2941
> Project: Flume
> Issue Type: Improvement
> Reporter: Lior Zeno
> Assignee: Mike Percy
> Priority: Minor
> Fix For: v1.7.0
>
>
> We should add the maven-checkstyle-plugin to the build process. This plugin
> can fail a build if the code does not honor the style of our project. This
> way we can make sure that we have one common style in the code. In addition,
> reviewers can focus on design, correctness, performance and other important
> coding aspects other than style issues.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
