> On 七月 29, 2016, 2:49 p.m., Attila Simon wrote: > > flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirSource.java, > > line 162 > > <https://reviews.apache.org/r/50378/diff/4/?file=1457769#file1457769line162> > > > > I think you just testing the filtering with this junit test. This can > > be done as well in the TestTaildirMatcher file without the need of creating > > a channel and transaction. Required complexity of such test would be closer > > to the unit idea.
I think tests in TestTaildirSource are used to test the config values, such as filename regex, header map usage and fileheader. Then it's ok to put this test in TestTaildirSource. On 七月 29, 2016, 2:49 p.m., qiao wen wrote: > > I think it is getting there to be committed. Some more iteration and it > > will be done. Keep up the good work! Thanks for you review. It's a honor to contribute for flume. - qiao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50378/#review144092 ----------------------------------------------------------- On 七月 29, 2016, 12:04 p.m., qiao wen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50378/ > ----------------------------------------------------------- > > (Updated 七月 29, 2016, 12:04 p.m.) > > > Review request for Flume. > > > Repository: flume-git > > > Description > ------- > > In our log management project, we wan't to track many log files like this: > /app/dir1/log.* > /app/dir2/log.* > ... > /app/dirn/log.* > But TaildirSource can't support wildcards in filegroup directory name. The > following config is expected: > a1.sources.r1.filegroups.fg = /app/*/log.* > > > Diffs > ----- > > flume-ng-doc/sphinx/FlumeUserGuide.rst 3f08d8b > > flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirMatcher.java > ad9f720 > > flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirMatcher.java > c341054 > > flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirSource.java > 097ee0b > > Diff: https://reviews.apache.org/r/50378/diff/ > > > Testing > ------- > > All tests in TestTaildirSource passed. > > > Thanks, > > qiao wen > >
