----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50378/#review167069 -----------------------------------------------------------
flume-ng-doc/sphinx/FlumeUserGuide.rst (line 1124) <https://reviews.apache.org/r/50378/#comment239196> Can you please reformat this so that the link would be correct? flume-ng-doc/sphinx/FlumeUserGuide.rst (line 1155) <https://reviews.apache.org/r/50378/#comment239198> Is there a way to unify regex vs. glob patterns in the path? Ie. either glob or regex all the way? Other than the things I've mentioned, the patch looks fine to me. - Balázs Donát Bessenyei On July 30, 2016, 5:33 a.m., qiao wen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50378/ > ----------------------------------------------------------- > > (Updated July 30, 2016, 5:33 a.m.) > > > Review request for Flume. > > > Repository: flume-git > > > Description > ------- > > In our log management project, we wan't to track many log files like this: > /app/dir1/log.* > /app/dir2/log.* > ... > /app/dirn/log.* > But TaildirSource can't support wildcards in filegroup directory name. The > following config is expected: > a1.sources.r1.filegroups.fg = /app/*/log.* > > > Diffs > ----- > > flume-ng-doc/sphinx/FlumeUserGuide.rst 3f08d8b > > flume-ng-sources/flume-taildir-source/src/main/java/org/apache/flume/source/taildir/TaildirMatcher.java > ad9f720 > > flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirMatcher.java > c341054 > > flume-ng-sources/flume-taildir-source/src/test/java/org/apache/flume/source/taildir/TestTaildirSource.java > 097ee0b > > Diff: https://reviews.apache.org/r/50378/diff/ > > > Testing > ------- > > All tests in TestTaildirSource passed. > > > Thanks, > > qiao wen > >