----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52279/#review150543 -----------------------------------------------------------
Please, reformat the code so that checkstyle doesn't fail flume-ng-core/src/main/java/org/apache/flume/source/NetcatUdpSource.java (lines 61 - 65) <https://reviews.apache.org/r/52279/#comment218555> These could be private flume-ng-core/src/main/java/org/apache/flume/source/NetcatUdpSource.java (lines 73 - 75) <https://reviews.apache.org/r/52279/#comment218557> These headers seem to be never added to the event flume-ng-core/src/main/java/org/apache/flume/source/NetcatUdpSource.java (line 112) <https://reviews.apache.org/r/52279/#comment218556> nit: writing flume-ng-core/src/main/java/org/apache/flume/source/NetcatUdpSource.java (line 113) <https://reviews.apache.org/r/52279/#comment218553> This return seems unnecessary. flume-ng-core/src/main/java/org/apache/flume/source/NetcatUdpSource.java (line 117) <https://reviews.apache.org/r/52279/#comment218554> This return seems unnecessary. flume-ng-core/src/test/java/org/apache/flume/source/TestNetcatUdpSource.java (line 28) <https://reviews.apache.org/r/52279/#comment218559> nit: unused import flume-ng-core/src/test/java/org/apache/flume/source/TestNetcatUdpSource.java (lines 51 - 52) <https://reviews.apache.org/r/52279/#comment218558> These fields are unused - Balázs Donát Bessenyei On Sept. 26, 2016, 9:32 p.m., Tristan Stevens wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52279/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2016, 9:32 p.m.) > > > Review request for Flume and Balázs Donát Bessenyei. > > > Repository: flume-git > > > Description > ------- > > Implementation is heavily based on the existing SyslogUDPSource - the tests > and implementation mirror that. We could consider making it a superclass of > SyslogUDPSource and removing the syslog parsing, if this was felt tidier. > > > Diffs > ----- > > flume-ng-core/src/main/java/org/apache/flume/source/NetcatUdpSource.java > PRE-CREATION > > flume-ng-core/src/test/java/org/apache/flume/source/TestNetcatUdpSource.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/52279/diff/ > > > Testing > ------- > > Unit tests provided. > > > Thanks, > > Tristan Stevens > >
