> On Sept. 27, 2016, 12:13 p.m., Balázs Donát Bessenyei wrote: > > flume-ng-core/src/main/java/org/apache/flume/source/NetcatUdpSource.java, > > lines 61-65 > > <https://reviews.apache.org/r/52279/diff/1/?file=1510380#file1510380line61> > > > > These could be private
changed - Tristan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52279/#review150543 ----------------------------------------------------------- On Oct. 3, 2016, 5:51 p.m., Tristan Stevens wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52279/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2016, 5:51 p.m.) > > > Review request for Flume and Balázs Donát Bessenyei. > > > Repository: flume-git > > > Description > ------- > > Implementation is heavily based on the existing SyslogUDPSource - the tests > and implementation mirror that. We could consider making it a superclass of > SyslogUDPSource and removing the syslog parsing, if this was felt tidier. > > > Diffs > ----- > > > flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java > 4f4073a > flume-ng-core/src/main/java/org/apache/flume/source/NetcatUdpSource.java > PRE-CREATION > > flume-ng-core/src/test/java/org/apache/flume/source/TestDefaultSourceFactory.java > baa8500 > > flume-ng-core/src/test/java/org/apache/flume/source/TestNetcatUdpSource.java > PRE-CREATION > flume-ng-doc/sphinx/FlumeUserGuide.rst ab71d38 > > Diff: https://reviews.apache.org/r/52279/diff/ > > > Testing > ------- > > Unit tests provided. > > > Thanks, > > Tristan Stevens > >
