----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52550/#review151557 -----------------------------------------------------------
Can you elaborate on "Testing passed". I think it would make sense to unit-test this in order to ensure the counters are incrementing properly. flume-ng-channels/flume-kafka-channel/src/main/java/org/apache/flume/channel/kafka/KafkaChannel.java (line 533) <https://reviews.apache.org/r/52550/#comment220002> I don't think this is in the correct place. The previous line adds the entire batch to the Put Success count. I think we want to add this in the doPut method instead? flume-ng-channels/flume-kafka-channel/src/main/java/org/apache/flume/channel/kafka/KafkaChannel.java (line 550) <https://reviews.apache.org/r/52550/#comment220003> Same thing here. I don't see why we need this here if we are already incrementing in the doTake()? - Jeff Holoman On Oct. 5, 2016, 10:51 a.m., Umesh Chaudhary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52550/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2016, 10:51 a.m.) > > > Review request for Flume. > > > Repository: flume-git > > > Description > ------- > > Added appropriate function calls to capture eventTakeAttemptCount and > eventPutAttemptCount in KafkaChannel > > > Diffs > ----- > > > flume-ng-channels/flume-kafka-channel/src/main/java/org/apache/flume/channel/kafka/KafkaChannel.java > 66b553a > > Diff: https://reviews.apache.org/r/52550/diff/ > > > Testing > ------- > > Testing Passed. > > > Thanks, > > Umesh Chaudhary > >
