> On Oct. 18, 2016, 9:44 a.m., Balázs Donát Bessenyei wrote: > > flume-ng-channels/flume-kafka-channel/src/test/java/org/apache/flume/channel/kafka/TestKafkaChannel.java, > > line 769 > > <https://reviews.apache.org/r/52550/diff/2/?file=1529617#file1529617line769> > > > > Do you think this Thread.sleep could be avoided? > > > > If not, do you think you can change it in a way that it will be > > not-so-prone to flakiness? > > (Maybe something like at https://reviews.apache.org/r/49025/diff/5#3 )
Need Thread.sleep to spawn the HTTPMetricsServer before making HTTP GET request for metrics. Reduced the sleep time for 10ms so that it would not show flakiness. On Oct. 18, 2016, 9:44 a.m., Umesh Chaudhary wrote: > > Thank you for the patch! > > > > Can you please rebase it on trunk so that it applies cleanly? > > > > Also, please reformat the code to pass checkstyle checks. Rebased in on trunk and fixed the checkstyle error. - Umesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52550/#review153062 ----------------------------------------------------------- On Oct. 19, 2016, 10:17 a.m., Umesh Chaudhary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52550/ > ----------------------------------------------------------- > > (Updated Oct. 19, 2016, 10:17 a.m.) > > > Review request for Flume, Balázs Donát Bessenyei, Jeff Holoman, and Mike > Percy. > > > Repository: flume-git > > > Description > ------- > > Added appropriate function calls to capture eventTakeAttemptCount and > eventPutAttemptCount in KafkaChannel > > > Diffs > ----- > > > flume-ng-channels/flume-kafka-channel/src/main/java/org/apache/flume/channel/kafka/KafkaChannel.java > 47c0634 > > flume-ng-channels/flume-kafka-channel/src/test/java/org/apache/flume/channel/kafka/TestKafkaChannel.java > 276fee1 > > Diff: https://reviews.apache.org/r/52550/diff/ > > > Testing > ------- > > # mvn -DfailIfNoTests=false > -Dtest=org.apache.flume.channel.kafka.TestKafkaChannel test > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 04:17 min > [INFO] Finished at: 2016-10-19T15:31:38+05:30 > [INFO] Final Memory: 98M/1210M > [INFO] > ------------------------------------------------------------------------ > > # mvn -pl flume-ng-channels -Drat.skip=true test > > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 1.108 s > [INFO] Finished at: 2016-10-19T15:44:52+05:30 > [INFO] Final Memory: 23M/309M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Umesh Chaudhary > >
