Hi Felix, I have just recognized that all the provided files do not have license. All of them must contain license, the big comment at the beginning that exists in other source files of the OOo.
The diff for the xtempfile.cxx file looks not so good, the old version is in XTempfile.cxx and the new one is in XTempFile.cxx. Actually the CVS is case-sensitive, so it is better to preserve the original name completely. The xtempfile.hxx file diff and idl-related diffs look good from the first view ( except the license ). Good that you have reminded me about the documentation, you are right it is expected to be done by us. You can prepare a preliminary one based on the idl documentation examples I have mentioned in previous mails ( for example offapi/com/sun/star/embed/XStorage.idl ), and we will discuss it. Also please add the license text to the idl files. Questions are welcome, if you have some please do not hesitate to ask. Best Regards, Mikhail. Zhang Xiaofei wrote: > Hi Mikhail, > > Sorry I don't have CVS installed on my machine yet, so I have to send > all the new and modified files to you via mail, plus I put the files in > different folders and generated 2 patch files manually with diff -urpN, > though I don't know if they are the same as those generated in CVS. > Could you have a look at them for me? :-) > > Best Regards, > Felix. > > P.S.: There is no documentation within the files yet, is it us supposed > to complete them, or the API Project members? > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
