Hi Felix, The patches look very good!
Some parts of the documentation should be corrected, they are described below. But they are either result of problems in existing UNO API documentation or quite minor: - the new documentation for the XStream part is not correct, but this is because the documentation of the XStream interface in XStream.idl file is wrong - closing of one ( input or output ) part of a stream does not close another part. This documentation is in conflict with for example XOutputStream.idl documentation and actually with all the current implementations of streams. Good that we have recognized it, it should be fixed, I think I will do it during integration of the patch. By the way, there is no need to copy the documentation of the used interfaces, because the documentation generated from idl-files will redirect to the base interfaces ( a short sentence would still probably be good ). It should be copied only in case the details of the behavior has changed. - the RemoveFile attribute controls whether the file will be automatically removed on object destruction So I would say that you can already attach the patches to the issue as they are, I will integrate them to one of our childworkspace with the minor changes and let them be tested. This task looks to be fixed, I will send you a new one soon :) Best Regards, Mikhail. Zhang Xiaofei wrote: > Hi Mikhail, > > Thank you for the direction, the modifications you suggested have been > made, please check the attachments. :-) > > Best Regards, > Felix. > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
