+1 (binding) Other than the usual things, I ran the FMPP test suite, and tested if Docgen generates identical output with 2.3.29.
I have spotted some unfinished work in lambdas (they were even marked with TODO comments...), but they aren't important, so it's OK to fix them in 2.3.30. (I will push fixes soon, but again that goes into 2.3.30.) On Sat, Aug 10, 2019 at 12:54 AM Daniel Dekany <[email protected]> wrote: > Hi all, > > Please vote on releasing FreeMarker 2.3.29! > > As there were changes in the last few days, don't skip testing with > your dependent > projects, even if you already did it recently. > > Release Notes: > https://freemarker.apache.org/builds/2.3.29-voting/versions_2_3_29.html > > Before proceed, you should know that FreeMarker 2.3.x, for a long > time, always releases a normal and a "gae" variant on the same time, > which are technically two independent source trees (Git branches). The > "gae" variant contains a few small modification in the Java source > code to be Google App Engine compliant, and has freemarker-gae as the > Maven artifact name. Otherwise the normal and the "gae" branches are > identical. Hence they will be voted on together. > > The commits to be voted upon are: > - Normal (non-gae) variant: > > https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=f70ac39487a7f0dc3ab693d36b9798ebf4456c7f > Commit hash: f70ac39487a7f0dc3ab693d36b9798ebf4456c7f > - "gae" variant: > > https://git-wip-us.apache.org/repos/asf?p=freemarker.git;a=commit;h=f87eb85972c331a5ca1ff065e8865cb984d769bb > Commit hash: f87eb85972c331a5ca1ff065e8865cb984d769bb > > The artifacts to be voted upon are located here: > https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.29/source/ > where the source release artifacts are: > - Normal (non-gae) variant: > apache-freemarker-2.3.29-src.tar.gz > - "gae" variant: > apache-freemarker-gae-2.3.29-src.tar.gz > > See the README.md inside them for build instructions! > > The release artifacts are signed with the following key: > https://people.apache.org/keys/committer/ddekany.asc > > For convenience, we also provide binaries, which also need to be checked: > https://dist.apache.org/repos/dist/dev/freemarker/engine/2.3.29/binaries/ > and Maven artifacts in the ASF Staging Repository: > > https://repository.apache.org/content/repositories/staging/org/freemarker/freemarker/2.3.29/ > > Please try out the package and vote! > > The vote is open for a minimum of 72 hours or until the necessary number of > votes (3 binding +1s) is reached. > > [ ] +1 Release this package as Apache FreeMarker 2.3.29 > [ ] 0 I don't feel strongly about it, but I'm okay with the release > [ ] -1 Do not release this package because... > > Please add "(binding)" if your vote is binding. > > -- > Thanks, > Daniel Dekany >
