Hi Woonsan, thanks for having a look - and nothing stops us making a nice common CLI tool :-)
Regarding remarks (improvement ideas) Having an easy way to add custom tools would be nice but a bit tricky * How to pick up custom tools - config file versus class path scanning? What dependencies to pull in? * How to integrate custom libs with the generated wrapper scripts - I would like to cleanly separate out-of-the-box freemarker-cli from user-specific changes, e.g. I support loading FreeMarker templates from “~/.freemarker-cli/templates” Using FreemarkerTask in a different environment * No problem to keep a shared “Configuration” Thanks in advance, Siegfried Goeschl > On 2 Dec 2019, at 21:02, Woonsan Ko <woon...@apache.org> wrote: > > Please see my comments inline. Thanks! > > On Tue, Nov 19, 2019 at 4:35 AM Siegfried Goeschl > <siegfried.goes...@gmail.com <mailto:siegfried.goes...@gmail.com>> wrote: >> >> Hi Woonsan, >> >> please see my comments below … >> >> Thanks in advance, >> >> Siegfried Goeschl >> >> >>> On 19 Nov 2019, at 00:03, Woonsan Ko <woon...@apache.org> wrote: >>> >>> Hi Siegfried, >>> >>> On Sun, Nov 17, 2019 at 1:02 PM Siegfried Goeschl >>> <siegfried.goes...@gmail.com> wrote: >>>> >>>> Hi folks, >>>> >>>> since I'm currently mostly busy with non-coding tasks I spent some time >>>> honing my coding skills - probably to no avail as my colleagues would say >>>> ;-) >>>> >>>> 1) I migrated my pet project "freemarker-cli" from Groovy to JDK 8 (see >>>> https://github.com/sgoeschl/freemarker-cli >>>> <https://github.com/sgoeschl/freemarker-cli>) >>>> >>>> 2) At >>>> https://github.com/sgoeschl/presentations/blob/master/javameetup/freemarker/slides/src/docs/asciidoc/index.adoc >>>> >>>> <https://github.com/sgoeschl/presentations/blob/master/javameetup/freemarker/slides/src/docs/asciidoc/index.adoc> >>>> you find a presentation I gave some while ago >>>> >>>> 3) I also wrote a Spring Boot FreeMarker sample project as part of the >>>> presentation (see >>>> https://github.com/sgoeschl/presentations/tree/master/javameetup/freemarker/demo >>>> >>>> <https://github.com/sgoeschl/presentations/tree/master/javameetup/freemarker/demo>) >>>> >>>> My plans / questions >>>> >>>> I would be awesome if I could get some feedback about "freemarker-cli" in >>>> its current JDK incarnation :-) Later on I will release 2.0.0 and push it >>>> to Maven Central. >>> >>> I like the idea in principle. We have some other "generators" - code >>> generators for example, but this simple transformation/generation in >>> CLI seems very useful too. Just as an example, I have seen my >>> colleagues writing python scripts to convert one format to another. >>> Your tool seems easier and more maintainable to me. >>> I'd like to try it out later this week. >> >> >> +1 > > I've take a look at the code. It is really nice! Thanks again for > sharing this great tool. I wish we could make a nice common CLI tool > out of this together. > > I have some other remarks (which could be improvement ideas): > - It would be nice if people can drop their jar or classes to register > a custom tool, not just built-in tools. e.g, custom xml stream based > reading tool, commons-vfs based tool, s3 tool, etc. > - Sometimes people might want to use the `FreeMarkerTask` in > multi-threaded env or framework-integrated env (e.g, spring-batch / > spring-boot). At the moment, `FreeMarkerTask` creates the FreeMarker > `Configuration` every time. It might be better to have an option to > pass a shareable `Configuration` object to the caller task for those > cases. > > Kind regards, > > Woonsan > >> >>> >>>> >>>> In the mean time I wrote three applications (micro services in new speak) >>>> using Apache FreeMarker and found it hard to find a starting point for a >>>> Spring Boot applications - therefore I wrote the sample project (see >>>> above). One way or the other a Spring Boot (and Micronaut) blue print >>>> should find its way into Apache FreeMarker officially. I think Apache >>>> FreeMarker is awesome for adding a developer UI to some micro service but >>>> developers don't care about the template engine but only about a quick and >>>> painless way to get the job done ... >>> >>> FWIW, in v3 branch, we also have a new submodule, freemarker-spring, >>> substituting the spring mvc jsp tag libraries: >>> - https://github.com/apache/freemarker/tree/3/freemarker-spring >>> Some examples in templates: >>> - >>> https://github.com/apache/freemarker/tree/3/freemarker-spring/src/test/resources/META-INF/web-resources/views/test/model >>> >>> The template models, which replaces the spring jsp taglibs, are more >>> lightweight and performant. >>> I had my own GitHub repo for demo purpose, but intended to merge it to >>> v3 branch someday: >>> - https://github.com/woonsan/spring-mvc-freemarker3-demo >>> It might be a bit outdated, but you will get the idea. >>> And, I assume that mvc examples would be helpful to make a nice boot >>> example with templates. >> >> Will check out the v3 branch ... >> >>> >>>> >>>> Anyone volunteering to give a presentation about Apache Freemarker at >>>> ApacheCon? I could do but I'm not really qualified :-) >>> >>> I can give a hand, and I know you're really a qualified presenter >>> (I've attended your session about JSPWiki before). >>> So, if there's anyone, like Daniel or someone else, I'd just help out >>> with anything. If no one can join in ApacheCon NA next year, I also >>> want to volunteer preparations or even presenting together. ;-) >>> >> >> I’m honoured - I think there were altogether less than 10 attendees for my >> two JSPWiki presentations @ ApacheCon :) >> >>> Kind regards, >>> >>> Woonsan >>> >>>> >>>> Thanks in advance, >>>> >>>> Siegfried Goeschl
