Yes it is a lot of work. The commit below focusses on the formatting of various Temporals, so no parsing etc. https://github.com/Jaaap/freemarker/commit/8bf5a91de2c47b191b5d68c7506abfbb350626ab <https://github.com/Jaaap/freemarker/commit/8bf5a91de2c47b191b5d68c7506abfbb350626ab>
Should i make a pull request based on this commit or are there intermediate steps to be taken? regards, Teun > On 2020-02-12, at 23:50, Daniel Dekany <[email protected]> wrote: > > No, you will only needed CLA when your pull request needs to be merged. > > Note that adding Java 8 support will have quite a lot consequences in FM. > Many parts touched. At least in principle, we should add a lot of new > TemplateModel subinterfaces... given how many types are there in java.time, > that will be awkward. And then integrating all that with all the places > that can now explicitly handle TemplateDateModel, TemplateDateTimeModel, > and TemplateTimeModel. So, yeah, it's not accidental that nobody has > invested into this yet. :) > -- > Best regards, > Daniel Dekany
