Am Donnerstag, 25. Januar 2007 07:40 schrieb Ph. Marek:
> > Ah, ok. I already feared that there'd be a technical reason to do so,
> > but if it's just misbehaviour it can be fixed. :-)
> Better this way?
> Please test and commit.

There's something rather strange going on... I retried with fsvs-1.0.15 
with and without this patch. In both cases fsvs ignored my partial commit 
directory and committed unrelated contents, one of the times the patched 
version started to scan all directories again, but the other times it 
did'n...

If my fsvs root is /home/a , my command line was:

  /home/a# fsvs ci -d -m 'PC test' ./b/c/

 - I also tried to specify the directory as b/c/ or b/c, to no avail - and 
fsvs started committing changes in b/D/E ...

Your path traversal patch was applied, so it does not reliably seem to fix 
the partial commit problem.

> Please commit the other patch, too ... I'd like to update and have it,
> too

I will do that soon, I just have not yet found time to update the tests; 
as usual I'm rather busy at the moment. Currently I'm happy if I manage 
to even test your changes... ;)

Hoever, this evening, or tomorrow eveing, I'll be on the train for a few 
hours and I plan to update the code during that time. I'll do some 
further tests to verify the above mentioned problems, and if it works, 
I'll commit the patch, if it doesn't I'll try to figure out test cases to 
provoke the misbehaviour.

Greetings,

  Gunter

-- 
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
AFPer: Incidentally, do you have strong opinions about the meanings of 
"alternate" and "alternative"?
TP: Yes. I think that pedants should be alternately ignored and flamed, 
unless there is a better alternative.        -- (Terry Pratchett and An 
AFPer, alt.fan.pratchett)
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+
+                   PGP-verschlüsselte Mails bevorzugt!                 +
+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+

Attachment: pgpXiwrbAOi7D.pgp
Description: PGP signature

Reply via email to