Hi Phil,
> The first one seems better to me.
I use dir_exclude_mtime for now, ok?
When putting the option definition in options.c, options.h and options.dox it
builds but it don't accept the option.
> Option name 'dir_exclude_mtime=no' unknown.
Code in options.c:
> [OPT__DIR_EXCLUDE_MTIME] = {
> .name="dir_exclude_mtime", .i_val=OPT__NO,
> .parse=opt___string2val, .parm=opt___yes_no,
> },
What do I miss here?
When I looked over the code it seems to me that I need to add the exclude mtime
code for every part in fsvs where also the filter option applies.
It looks like repeating the filter behaviour again. I only wonder where to start
because I don't find a function to extend with the exclude check. Can you give
me a small hint where to start?
Cheers,
Gunnar
P.Marek wrote:
>> P.Marek wrote:
>>>> Is it possible to use an option like -ofilter=mtime-dir so only adapting
>>>> the
>>>> existing mtime filter. Do you think this is easy possible to do or do you
>>>> see
>>>> another way to do that?
>>> Well, I believe that this should be an entirely new config option; the
>>> filter options
>>> are convoluted enough.
>>>
>>> Maybe "dir-no-mtime-only" or something like that?
>> So you think of a seperate option?
>> For a filter option I see it easier to be done because the code for filtering
>> mtime already exist and only needs to be extended by checking for the type of
>> the fs object.
> Yes, but the logic for "-v" would get even harder to understand.
> So yes, you're in the right place for checking, but I'd simply use a new
> option.
>
>>> Do you want to do the dir-no-mtime-only option? Better name welcome.
>> I can try but would first try with the existing code for mtime in filter, I
>> am a
>> lazy guy :-)
> Would it make sense to wait with the release, ie. do you think you can make
> it in the
> next two weeks?
>
>> Other suggestion would be dir-exclude-mtime, exclude-dir-mtime-changes
>> (perhaps
>> open the naming for further exclude options that may follow)...
> The first one seems better to me.
>
>
> Regards,
>
> Phil
>
------------------------------------------------------
http://fsvs.tigris.org/ds/viewMessage.do?dsForumId=3923&dsMessageId=2446484
To unsubscribe from this discussion, e-mail: [[email protected]].
