Hi Phil,
P.Marek wrote:
> Hello Gunnar!
>
>>> The first one seems better to me.
>> I use dir_exclude_mtime for now, ok?
> Ok.
>
>> When putting the option definition in options.c, options.h and options.dox it
>> builds but it don't accept the option.
> Maybe the name is too long?
Indeed, its the length of the optionname. Is there any reason for a restriction
of optionname length?
>>
>> When I looked over the code it seems to me that I need to add the exclude
>> mtime
>> code for every part in fsvs where also the filter option applies.
> No, it should be enough to add that either to st__action() (to just avoid
> showing them,
> because on commit it might make sense again), or to ac__dispatch() - that
> should be used
> everywhere. (?)
>
>> It looks like repeating the filter behaviour again. I only wonder where to
>> start
>> because I don't find a function to extend with the exclude check. Can you
>> give
>> me a small hint where to start?
> Do the above hints help?
Yes, that helps a lot. I was wondering if it does make sense to update the mtime
of directories if this option is active. It's best to reduce it to status only
st__action() for now.
Another issue regarding config_dir.
I did a test against ssl setup (the same you find in branch).
With no config_dir option set the search path for credential information is now:
> /etc/fsvs/svn/auth/svn.ssl.server/06efd6678d902375072f17361922b4b2
Is the "svn" before "auth" intentional? I could live with that just want to
know.
When config_dir option is set to:
> config_dir=/etc/fsvs
I get this warning:
> An error occurred: Malformed file (200002)
> in hlp__get_svn_config: svn_config_get_config: /etc/fsvs/config:1: Section
> header expected
When I use:
> config_dir=/home/gthielebein/.subversion
It correctly identifies the folder. But a) it ignores my global server file in
/etc/fsvs/(svn/)auth/server and b) storing of password and ssl-credentials
failed:
> 14:00:45.898952
> open("/home/gthielebein/.subversion/auth/svn.ssl.client-passphrase/d8354ba99a7d33871875f62b3bfb303e",
> O_WRONLY|O_CREAT|O_TRUNC, 0666) = -1 ENOENT (No such file or directory)
> 14:02:16.320384
> open("/home/gthielebein/.subversion/auth/svn.ssl.client-passphrase/d8354ba99a7d33871875f62b3bfb303e",
> O_WRONLY|O_CREAT|O_TRUNC, 0666) = -1 ENOENT (No such file or directory)
Is it hard to create the parent folders within fsvs when they do not exists.
This would mimic the behaviour of the svn client.
Cheers,
Gunnar
>
>
> Regards,
>
> Phil
>
------------------------------------------------------
http://fsvs.tigris.org/ds/viewMessage.do?dsForumId=3923&dsMessageId=2447065
To unsubscribe from this discussion, e-mail: [[email protected]].
