Hi Justin,
Thank you very much for your thorough review and detailed feedback — it’s
greatly appreciated!
We’ve carefully addressed all the licensing and header issues you raised:
1.
Apache License headers have been added to all applicable source files,
including:
- .js, .ts, and .tsx files in the web dashboard and geaflow web;
- the .ftl file in the GeaFlow DSL parser;
- empty or previously missing source files (e.g., server.js,
CommonUtil.ts, etc.).
2.
LICENSE and NOTICE files have been updated:
- The Netty-derived or other files (CleanerJava6.java, CleanerJava9.java,
AbstractFileRegion.java, etc.) are now properly declared in LICENSE,
and the Netty or other project's copyright notice has been added to
NOTICE.
- The GeaflowMemoryViewWriterBenchmark.java file now correctly
contains ASF header.
- The mock file flameGraphContent.ts was confirmed as
project-original content and now includes the standard ASF header.
- The intellij-java-style.xml file is confirmed as project-authored
and now includes an XML-formatted ASF license header.
3.
"Produced by Ant Group" references in the web dashboard have been
removed.
4.
GOVERNANCE.md has been updated to better reflect Apache consensus
practices, per your suggestion and [13].
5.
We’ve also ensured that all generated or excluded directories (e.g.
node_modules, node) are properly ignored in RAT checks and not included
in the source release.
A new release candidate (RCx) incorporating all these fixes is ready and
will be posted shortly for re-vote.
Thanks again for your guidance — this has significantly helped us improve
our compliance with Apache IP policies.
Kind regards,
loogn
On behalf of the Apache GeaFlow (incubating) community
Justin Mclean <[email protected]> 于2025年11月3日周一 13:23写道：
> HI,
>
> -1 (binding) due to some licensing and header issues. I suggest using the
> work-in-progress disclaimer for your first couple of releases and note
> these sort of issues in the disclaimer. [1]
>
> I checked:
> - incubating in name
> - signatures and hashes are fine
> - DISCLAIMER exists
> - LICENSE is misisng information (see below)
> - NOTICE looks OK, but I’m not 100% sure why some ASF projects are
> mentioned as the LICENSE doesn't list them
> - A number of files are misisng ASF headers that shoudl have them e.g. .js
> files and .tsx files in the web dashboard and .ftl file in the geaflow dsl
> parser
> - No unexpected binary files
> - I didnn’t try to compile from source
>
> The LICENSE file has issues due to:
> This file [2] looks to contain code Copyright 2020 Andrei Pangin.
> This file [3] incorrectly has an ASF header and is misisng from the
> LICENSE file. Its license is unknown.
> These files [4][5] have an ASF header and are missing from the LICENSE
> file.
> These files [6][7][8][9][10][11][12] are not mentioned in the LICENSE (and
> possibly the NOTICE, depending on their origin).
>
> There are some other minor issues, eg "Produced by Ant Group” in the web
> dashboard.
>
> I also noticed in GOVERNANCE.MD, you mention " For important changes, the
> PMC may call a vote.” While this is correct, it should be rare and is
> usually used to confirm consensus. Please see [13].
>
> Kind Regards,
> Justin
>
> 1.
> https://incubator.apache.org/policy/incubation.html#work_in_progress_disclaimer
> 2. ./geaflow/geaflow-dashboard/web-dashboard/mock/flameGraphContent.ts
> 3.
> ./geaflow/geaflow-memory/src/test/java/org/apache/geaflow/memory/jmh/GeaflowMemoryViewWriterBenchmark.java
> 4.
> ./geaflow/geaflow-memory/src/main/java/org/apache/geaflow/memory/cleaner/CleanerJava6.java
> 5.
> ./geaflow/geaflow-memory/src/main/java/org/apache/geaflow/memory/cleaner/CleanerJava9.java
> 6. ./tools/intellij-java-style.xml
> 7. ./geaflow/geaflow-dashboard/web-dashboard/server.js
> 8. ./geaflow/geaflow-dashboard/web-dashboard/src/util/TableUtil.tsx
> 9. ./geaflow/geaflow-dashboard/web-dashboard/src/util/CommonUtil.ts
> 10.
> ./geaflow-kubernetes-operator/geaflow-kubernetes-operator-web/web-dashboard/server.js
> 11.
> ./geaflow-kubernetes-operator/geaflow-kubernetes-operator-web/web-dashboard/src/util/CommonUtil.ts
> 12. ./tools/intellij-java-style.xml
> 13.
> https://cwiki.apache.org/confluence/display/INCUBATOR/Voting+and+Consensus+in+Practice
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
>
