Hi Justin,
Thank you again for your continued guidance — your latest comments helped
us catch an important nuance in ASF policy.
We’ve now made the following additional corrections based on your feedback
and [1]:
- Removed the ASF license header from all third-party derived files
(e.g., those from Netty, Presto, etc.).
As clarified in ASF policy, modified third-party files should
retain only their original license headers, without adding the ASF
boilerplate. We had previously misunderstood this point, and we appreciate
you pointing it out.
- Kept the original copyright and license notices intact in all derived
files, as required by their respective upstream licenses.
- Simplified the LICENSE file: while we retained the list of derived
files and their origins for clarity and traceability, we removed redundant
repetition of copyright lines that are already present in the source file
headers.
All changes have been verified against the ASF Licensing How-To and the
source header guidelines.
A new release candidate (RC3) incorporating these final licensing
adjustments will be posted shortly for re-vote.
Thanks once more for your patience and expert review — it has been
invaluable in helping us meet ASF compliance standards.
Kind Regards,
loogn
On behalf of the Apache GeaFlow (incubating) community
Justin Mclean <[email protected]> 于2025年11月5日周三 06:48写道：
> HI,
>
> Thanks for improving this.
>
> > 2. LICENSE file:
> > We have restructured it to clearly specify:
> >
> > - The origin (project name, URL, and version) of each third-party
> > component;
> > - The original copyright notice from each upstream project;
> > - The exact list of derived files in our codebase.
>
> There is probably no need to list the copyright line, as for non-ASF
> project, this should be in the file headers. However, I don't think this is
> an issue.
>
> > 3. Source file headers:
> >
> > - All derived files (e.g., those from Netty, Flink, Spark, etc.) retain
> > their original copyright notices and include the ASF license header for
> > modifications, as required.
>
> The ASF header should generally not be added to any third-party files,
> even if modifications have been made. Please see [1]
>
> Kind Regards,
> Justin
>
> 1., https://www.apache.org/legal/src-headers.html#3party
