[ https://issues.apache.org/jira/browse/GEARPUMP-339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16115825#comment-16115825 ]
ASF GitHub Bot commented on GEARPUMP-339: ----------------------------------------- Github user huafengw commented on a diff in the pull request: https://github.com/apache/incubator-gearpump/pull/212#discussion_r131545040 --- Diff: streaming/src/main/scala/org/apache/gearpump/streaming/dsl/scalaapi/StreamApp.scala --- @@ -62,6 +62,17 @@ class StreamApp( val dag = planner.plan(graph) StreamApplication(name, dag, userConfig) } + + def source[T](dataSource: DataSource, parallelism: Int = 1, + conf: UserConfig = UserConfig.empty, description: String = "source"): Stream[T] = { + implicit val sourceOp = DataSourceOp(dataSource, parallelism, description, conf) --- End diff -- Has to be implicit? > Improve ScalaDoc for all public classes > --------------------------------------- > > Key: GEARPUMP-339 > URL: https://issues.apache.org/jira/browse/GEARPUMP-339 > Project: Apache Gearpump > Issue Type: Improvement > Affects Versions: 0.8.4 > Reporter: Manu Zhang > Assignee: Manu Zhang > > All public classes should have ScalaDoc and any warnings should be fixed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)