Github user metatype commented on the pull request:
https://github.com/apache/incubator-geode/commit/36007c295827d29a182faadf591169b3d2691e7a#commitcomment-19939398
In
geode-core/src/test/java/org/apache/geode/internal/cache/FireAndForgetFunctionOnAllServersDUnitTest.java:
In
geode-core/src/test/java/org/apache/geode/internal/cache/FireAndForgetFunctionOnAllServersDUnitTest.java
on line 56:
@ameybarve15 Thanks for updating the PR but I think you missed my point.
Using Awatility is nice because all this is prebuilt. In addition, if the
condition is not met during the timeout, a `ConditionTimeoutException` will be
thrown. This makes analyzing the failure much simpler.
See the docs here:
https://github.com/awaitility/awaitility/wiki/Usage
Here's an example from
`geode-core/src/test/java/org/apache/geode/internal/cache/partitioned/PersistentPartitionedRegionDUnitTest.java`:
```
await().atMost(30, SECONDS).until(() -> {
return (cache == null || cache.isClosed());
});
```
@kirklund is planning to do a Geode Clubhouse on this topic soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
