[ 
https://issues.apache.org/jira/browse/GEODE-2476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872316#comment-15872316
 ] 

ASF GitHub Bot commented on GEODE-2476:
---------------------------------------

Github user pivotal-jbarrett commented on a diff in the pull request:

    https://github.com/apache/geode-native/pull/13#discussion_r101824812
  
    --- Diff: src/CMakeLists.txt ---
    @@ -224,7 +222,7 @@ add_subdirectory(cppcache)
     add_subdirectory(cryptoimpl)
     add_subdirectory(dhimpl)
     add_subdirectory(sqliteimpl)
    -add_subdirectory(gfcpp)
    +add_subdirectory(getversion)
    --- End diff --
    
    If they are relying on it then their scripts will break either way. There 
are better ways to get version. I don't think I have ever seen anyone anywhere 
use it. I don't even see it in our documents. I say kill it!


> Replace gfcpp with geode
> ------------------------
>
>                 Key: GEODE-2476
>                 URL: https://issues.apache.org/jira/browse/GEODE-2476
>             Project: Geode
>          Issue Type: Improvement
>          Components: native client
>            Reporter: Michael Dodge
>            Assignee: Michael Dodge
>
> The substring "gfcpp" still occurs in some places in the native client 
> codebase. It ought to be replaced with "geode" or "geode-native", whichever 
> makes more sense on a case-by-case basis.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to