[
https://issues.apache.org/jira/browse/GEODE-2476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872323#comment-15872323
]
ASF GitHub Bot commented on GEODE-2476:
---------------------------------------
Github user pivotal-jbarrett commented on a diff in the pull request:
https://github.com/apache/geode-native/pull/13#discussion_r101825168
--- Diff: src/cppcache/include/geode/AttributesFactory.hpp ---
@@ -1,7 +1,7 @@
#pragma once
-#ifndef GEODE_GFCPP_ATTRIBUTESFACTORY_H_
-#define GEODE_GFCPP_ATTRIBUTESFACTORY_H_
+#ifndef GEODE_GEODE_ATTRIBUTESFACTORY_H_
--- End diff --
I see an argument that `include/geode/` is the root for the public headers,
therefore the guards should be `GEODE_ATTRIBUTESFACTORY_H_`.
> Replace gfcpp with geode
> ------------------------
>
> Key: GEODE-2476
> URL: https://issues.apache.org/jira/browse/GEODE-2476
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Michael Dodge
> Assignee: Michael Dodge
>
> The substring "gfcpp" still occurs in some places in the native client
> codebase. It ought to be replaced with "geode" or "geode-native", whichever
> makes more sense on a case-by-case basis.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
