----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57573/#review168945 -----------------------------------------------------------
Fix it, then Ship it! geode-core/src/test/java/org/apache/geode/internal/statistics/DiskSpaceLimitIntegrationTest.java Lines 395-396 (original), 399-401 (patched) <https://reviews.apache.org/r/57573/#comment241255> Is there any possibility that the dirOfDeletedFiles will not exist in "dir"? It seems more robust to me to explicity remove the deleted files dir from the dir.listFiles() rather than arbitarily returning length - 1. Something like List listOfFiles = Arrays.asList(dir.listFiles()); listOfFiles.remove(dirOfDeletedFiles.getName()); return listOfFiles.size(); - Ken Howe On March 13, 2017, 11:31 p.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57573/ > ----------------------------------------------------------- > > (Updated March 13, 2017, 11:31 p.m.) > > > Review request for geode, Jinmei Liao, Jared Stewart, Kevin Duling, Ken Howe, > and Patrick Rhomberg. > > > Bugs: GEODE-2648 > https://issues.apache.org/jira/browse/GEODE-2648 > > > Repository: geode > > > Description > ------- > > GEODE-2648: always move deleted files to dirOfDeletedFiles > > Fix flaky test by always moving deleted files to dirOfDeletedFiles to avoid > race condition in which file is deleted before its presence can be detected. > > > Diffs > ----- > > > geode-core/src/test/java/org/apache/geode/internal/statistics/DiskSpaceLimitIntegrationTest.java > 5d94fa0ba32aabc0f0bfc396d99d0b5ef9572360 > > > Diff: https://reviews.apache.org/r/57573/diff/1/ > > > Testing > ------- > > DiskSpaceLimitIntegrationTest > precheckin in progress > > > Thanks, > > Kirk Lund > >
