Github user kirklund commented on a diff in the pull request:

    https://github.com/apache/geode/pull/565#discussion_r121195985
  
    --- Diff: 
geode-core/src/main/java/org/apache/geode/cache/query/internal/index/AbstractIndex.java
 ---
    @@ -2002,7 +2002,8 @@ void populateListForEquiJoin(List list, Object 
outerEntries, Object innerEntries
        */
       synchronized void setPdxStringFlag(Object key) {
         // For Null and Undefined keys do not set the isIndexedPdxKeysFlagSet 
flag
    -    if (key == null || key == IndexManager.NULL || key == 
QueryService.UNDEFINED) {
    +    if (isIndexedPdxKeysFlagSet || key == null || key == IndexManager.NULL
    --- End diff --
    
    Looks like you have two flags for the same thing... isIndexedPdxKeys and 
isIndexedPdxKeysFlagSet?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to