Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/565#discussion_r121196596
--- Diff:
geode-core/src/main/java/org/apache/geode/cache/query/internal/index/AbstractIndex.java
---
@@ -2002,7 +2002,8 @@ void populateListForEquiJoin(List list, Object
outerEntries, Object innerEntries
*/
synchronized void setPdxStringFlag(Object key) {
// For Null and Undefined keys do not set the isIndexedPdxKeysFlagSet
flag
- if (key == null || key == IndexManager.NULL || key ==
QueryService.UNDEFINED) {
+ if (isIndexedPdxKeysFlagSet || key == null || key == IndexManager.NULL
--- End diff --
They are slightly different. The isIndexedPdxKeys is represents whether
the index is storing pdx as keys. The isIndexedPdxKeysFlagSet, is a boolean
that is used as a short circuit to only call the method once. I guess it was a
performance "enhancement" to not call the method over and over for every value
and just call it only for the first call.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
