Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128386591
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandlerJUnitTest.java
---
@@ -64,11 +72,10 @@ public void setUp() throws Exception {
public void test_puttingTheEncodedEntryIntoRegion() throws
UnsupportedEncodingTypeException,
CodecNotRegisteredForTypeException,
CodecAlreadyRegisteredForTypeException {
PutRequestOperationHandler operationHandler = new
PutRequestOperationHandler();
- ClientProtocol.Response response =
+ Result<RegionAPI.PutResponse> result =
operationHandler.process(serializationServiceStub,
generateTestRequest(), cacheStub);
-
Assert.assertEquals(ClientProtocol.Response.ResponseAPICase.PUTRESPONSE,
- response.getResponseAPICase());
+ Assert.assertNotNull(result);
--- End diff --
We should assert that we got back a Success Object rather than just result
!= null
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
