Github user kohlmu-pivotal commented on a diff in the pull request:
https://github.com/apache/geode/pull/646#discussion_r128386349
--- Diff:
geode-protobuf/src/test/java/org/apache/geode/protocol/protobuf/operations/PutRequestOperationHandlerJUnitTest.java
---
@@ -124,20 +128,19 @@ public void test_RegionThrowsClasscastException()
throws CodecAlreadyRegisteredF
when(regionMock.put(any(), any())).thenThrow(ClassCastException.class);
PutRequestOperationHandler operationHandler = new
PutRequestOperationHandler();
- ClientProtocol.Response response =
+ Result<RegionAPI.PutResponse> result =
operationHandler.process(serializationServiceStub,
generateTestRequest(), cacheStub);
-
Assert.assertEquals(ClientProtocol.Response.ResponseAPICase.ERRORRESPONSE,
- response.getResponseAPICase());
+ Assert.assertTrue(result instanceof Failure);
--- End diff --
Do we need to assert at the error message
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
