Github user jhuynh1 commented on a diff in the pull request:
https://github.com/apache/geode/pull/609#discussion_r129624935
--- Diff:
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesIntegrationTest.java
---
@@ -290,6 +295,24 @@ public void queryJsonObject() throws Exception {
}
@Test()
+ public void testWaitUntilFlushedForException() throws Exception {
+ Map<String, Analyzer> fields = new HashMap<String, Analyzer>();
+ fields.put("name", null);
+ fields.put("lastName", null);
+ fields.put("address", null);
+
luceneService.createIndexFactory().setFields(fields).create(INDEX_NAME,
REGION_NAME);
+ Region region =
cache.createRegionFactory(RegionShortcut.PARTITION).create(REGION_NAME);
+ final LuceneIndex index = luceneService.getIndex(INDEX_NAME,
REGION_NAME);
+
+ // This is to send IllegalStateException from WaitUntilFlushedFunction
+ String nonCreatedIndex = "index2";
+
+ boolean b =
+ luceneService.waitUntilFlushed(nonCreatedIndex, REGION_NAME,
60000, TimeUnit.MILLISECONDS);
+ assertFalse(b);
--- End diff --
So the end result would be the wait for flush function would return false
(it did not flush) and a message would be logged on the server side. Based on
the proposed fix of returning the exception, we would have been doing something
similar anyways. The client would have seen a false (because the function
handled the exception and returned false)
So I guess having the test check for false would be just fine after all :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
