Github user jhuynh1 commented on a diff in the pull request:

    https://github.com/apache/geode/pull/609#discussion_r132497282
  
    --- Diff: 
geode-lucene/src/test/java/org/apache/geode/cache/lucene/LuceneQueriesIntegrationTest.java
 ---
    @@ -331,6 +331,29 @@ public void queryJsonObject() throws Exception {
       }
     
       @Test()
    +  public void waitUntilFlushThrowsIllegalStateExceptionWhenAEQNotFound() 
throws Exception {
    +    Map<String, Analyzer> fields = new HashMap<>();
    +    fields.put("name", null);
    +    fields.put("lastName", null);
    +    fields.put("address", null);
    +    
luceneService.createIndexFactory().setFields(fields).create(INDEX_NAME, 
REGION_NAME);
    +    Region region = 
cache.createRegionFactory(RegionShortcut.PARTITION).create(REGION_NAME);
    +    final LuceneIndex index = luceneService.getIndex(INDEX_NAME, 
REGION_NAME);
    +
    +    // This is to send IllegalStateException from WaitUntilFlushedFunction
    +    String nonCreatedIndex = "index2";
    +    boolean result = false;
    +    try {
    +      result = luceneService.waitUntilFlushed(nonCreatedIndex, 
REGION_NAME, 60000,
    +          TimeUnit.MILLISECONDS);
    --- End diff --
    
    I think there should be a fail() here,after the all to waitUntilFlushed, if 
we are expecting an exception to be thrown and it doesn't get thrown.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to