Github user PurelyApplied commented on the issue:
https://github.com/apache/geode/pull/652
@jaredjstewart I don't know why I didn't think to put my questions here
instead of imbedding them in my code, just to be removed later. I clearly
wasn't on my A-game.
1. In my addition to `GfshRule` to extend the classpath, it was unclear to
me whether using `ProcessBuilder`'s `environment` method was properly OS
agnostic. (Looking at it again, it also appears that I left variable names `p`
and `m` in place instead of more meaningful names. Ugh.)
2. In the `GfshExitCodeStatuscommandsDUnitTest`, I couldn't decide if the
utility functions generating the actual `gfsh` command would look better
inlined into the test function or as a function call.
3. Akin to the "Should `gfsh help` actually be returning non-zero",
existing behavior is to exit with a zero when gfsh is interrupted
(`Launcher.java:227`). Is an interruption assumed to be intentional and we
should return a zero, or should that actually be returning a nonzero?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
