----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61487/#review182347 -----------------------------------------------------------
geode-core/src/main/java/org/apache/geode/internal/cache/tier/InternalClientMembership.java Line 292 (original), 292 (patched) <https://reviews.apache.org/r/61487/#comment258218> I might be missing something, but would callers of the no-arg variant `getClientQueueSizes()` potentially be prone to the same deadlock that originally affected `CacheServerBridge.getNumSubscriptions`? geode-core/src/test/java/org/apache/geode/management/internal/beans/CacheServerBridgeClientMembershipRegressionTest.java Lines 53 (patched) <https://reviews.apache.org/r/61487/#comment258220> I wonder if `startedExecuting` and `finishedExecuting` might make the intent of these variables clearer. geode-core/src/test/java/org/apache/geode/management/internal/beans/CacheServerBridgeClientMembershipRegressionTest.java Lines 91 (patched) <https://reviews.apache.org/r/61487/#comment258219> I really like this style of this test! geode-core/src/test/java/org/apache/geode/management/internal/beans/CacheServerBridgeClientMembershipRegressionTest.java Lines 97 (patched) <https://reviews.apache.org/r/61487/#comment258222> It might be nice to have a commment (or to wrap line this in a named method) to indicate that this line is expected to obtain the lock on `CacheFactory`. - Jared Stewart On Aug. 8, 2017, 12:19 a.m., Kirk Lund wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61487/ > ----------------------------------------------------------- > > (Updated Aug. 8, 2017, 12:19 a.m.) > > > Review request for geode, Emily Yeh, Jinmei Liao, Jared Stewart, Ken Howe, > and Patrick Rhomberg. > > > Bugs: GEODE-3407 > https://issues.apache.org/jira/browse/GEODE-3407 > > > Repository: geode > > > Description > ------- > > Change InternalClientMembership to not synchronize on CacheFactory > by accepting Cache parameter from CacheServerBridge. > > New regression test confirms bug and this fix. > > > Diffs > ----- > > > geode-core/src/main/java/org/apache/geode/internal/cache/tier/InternalClientMembership.java > 504081d65515adb294dd43ecffee450477f08339 > > geode-core/src/main/java/org/apache/geode/management/internal/beans/CacheServerBridge.java > 728402c8a290d88026db753657e26e5f7440a990 > > geode-core/src/main/java/org/apache/geode/management/internal/beans/ServerBridge.java > 6834998da13deec5e074a61e5373ec2f8dce2ad7 > > geode-core/src/test/java/org/apache/geode/management/internal/beans/CacheServerBridgeClientMembershipRegressionTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/61487/diff/1/ > > > Testing > ------- > > precheckin in progress > > > Thanks, > > Kirk Lund > >
