+1 Deprecating ALL_KEYS option; I believe this is added before we supported regex support.
Doesn't seems like a new API is needed. The regex java doc clearly specifies the effect of ".*". +1 for deprecating list argument; and replacing with new API. -Anil. On Thu, Nov 16, 2017 at 3:36 PM, Jason Huynh <jhu...@pivotal.io> wrote: > For GEODE-3813 <https://issues.apache.org/jira/browse/GEODE-3813>: Region > registerInterest API usage of type parameters is broken > <https://issues.apache.org/jira/browse/GEODE-3813> > > > The current API to registerInterest allows a special string token > “ALL_KEYS” to be passed in as the parameter to registerInterest(T key). > This special token causes the registerInterest to behave similar to > registerInterestRegex(“.*”). As the ticket states, if the region has been > typed to anything other than Object or String, the usage of “ALL_KEYS” as a > parameter results in a compilation error. > > > Proposals: > > I would like to deprecate the special string “ALL_KEYS” and document a > workaround of using registerInterestRegex(“.*”) or we can add a new API > called registerInterestAllKeys() > > > I think we should also deprecate passing a List Object of keys into > registerInterest. It has the same compilation restrictions as “ALL_KEYS” > when the region is key constrained/typed. The reason why List would be > used is to allow registering multiple keys at once. Instead, we can add a > new var arg API like registerInterest(T… keys). This problem and solution > was also documented in the ticket by the ticket creator (Kirk Lund) > > > > Thanks, > > -Jason >
