I'm keeping INFRA-15727 to confirm that the changes have also been made to the geode-native and geode-examples repos.
On Wed, Dec 27, 2017 at 3:41 PM, Kirk Lund <[email protected]> wrote: > Karen just submitted a PR (#1208). It posted a nice short comment about > the PR to GEODE-4170 without diffs. Looks good to me! > > I'm going to close INFRA-15727 as fixed. If anyone notices anything not > quite right, please let me know and provide a URL. > > Thanks, > Kirk > > On Wed, Dec 27, 2017 at 3:12 PM, Dave Barnes <[email protected]> wrote: > >> I must have just missed the cutoff - my PR (#1207), which I created at >> 2:48, generated diffs in the JIRA. >> >> On Wed, Dec 27, 2017 at 3:06 PM, Kirk Lund <[email protected]> wrote: >> >> > INFRA has made the change. Does anyone have a PR ready to submit so I >> can >> > confirm the behavior on a Jira ticket? >> > >> > On Wed, Dec 27, 2017 at 12:57 PM, Kirk Lund <[email protected]> wrote: >> > >> > > I filed a request with INFRA to exclude pull request diffs from Jira >> > > comments. >> > > >> > > https://issues.apache.org/jira/browse/INFRA-15727 >> > > >> > > On Mon, Dec 18, 2017 at 12:33 PM, William Markito Oliveira < >> > > [email protected]> wrote: >> > > >> > >> +1 for removing the diff - Link to the PR should be good enough. >> > >> >> > >> On Mon, Dec 18, 2017 at 1:18 PM, Jacob Barrett <[email protected]> >> > >> wrote: >> > >> >> > >> > +1 for reducing noise! >> > >> > >> > >> > On Mon, Dec 18, 2017 at 10:03 AM Joey McAllister < >> > >> [email protected]> >> > >> > wrote: >> > >> > >> > >> > > (Er, from JIRA ticket comments, that is.) >> > >> > > >> > >> > > On Mon, Dec 18, 2017 at 10:02 AM Joey McAllister < >> > >> [email protected] >> > >> > > >> > >> > > wrote: >> > >> > > >> > >> > > > +1 to removing the diffs from JIRA tickets. >> > >> > > > >> > >> > > > On Mon, Dec 18, 2017 at 9:58 AM Dan Smith <[email protected]> >> > >> wrote: >> > >> > > > >> > >> > > >> Hi Kirk, >> > >> > > >> >> > >> > > >> I think this is will probably require a request to infra. You >> can >> > >> > file a >> > >> > > >> JIRA with infra assuming we have consensus to get rid of the >> > diffs >> > >> > (huge >> > >> > > >> +1 >> > >> > > >> from me:) >> > >> > > >> >> > >> > > >> Also, please don't cross post with private@geode. The private >> > list >> > >> > > should >> > >> > > >> *only* be used for things that can't be discussed publicly. >> > >> > > >> >> > >> > > >> -Dan >> > >> > > >> >> > >> > > >> https://www.apache.org/dev/infra-contact >> > >> > > >> >> > >> > > >> On Mon, Dec 18, 2017 at 9:43 AM, Kirk Lund <[email protected]> >> > >> wrote: >> > >> > > >> >> > >> > > >> > Since we switched to GitBox for Geode, all Pull Requests are >> > >> > resulting >> > >> > > >> in >> > >> > > >> > huge diffs being posted to the comments on Geode Jira >> tickets. >> > >> Some >> > >> > of >> > >> > > >> > these are resulting in hangs trying to open certain Jira >> > tickets. >> > >> > I'd >> > >> > > >> like >> > >> > > >> > to determine what our options are for changing how this is >> > >> > configured. >> > >> > > >> > >> > >> > > >> > I looked through all of the options in the administration >> > screens >> > >> > for >> > >> > > >> > Geode Jira but couldn't find anything other than a link to >> > INFRA >> > >> > > GitHub >> > >> > > >> > Integration that I don't have permission to access ( >> > >> > > >> > >> > >> > > >> >> > >> > > https://issues.apache.org/jira/plugins/servlet/project- >> > >> > config/GEODE/fields >> > >> > > >> > -- search down for "GitHub Integration"). >> > >> > > >> > >> > >> > > >> > Does anyone know where to change this configuration or is >> this >> > a >> > >> > > request >> > >> > > >> > that needs to go to ASF INFRA? >> > >> > > >> > >> > >> > > >> > Thanks, >> > >> > > >> > Kirk >> > >> > > >> > >> > >> > > >> >> > >> > > > >> > >> > > >> > >> > >> > >> >> > > >> > > >> > >> > >
