Bruce, would it make sense to for now revert the suspect change to the test? At that point we should be back to full green and we all can without a doubt go back to our usual flow of merging to develop.
Thoughts? On Thu, Feb 7, 2019 at 2:37 PM Kirk Lund <kl...@apache.org> wrote: > Hmm, and that was another false search hit in Jira! Searching for > WANRollingUpgradeNewSenderProcessOldEvent in Jira brings up GEODE-3967 > which apparently does NOT involve that test. So, maybe we found another > flaky test. > > Jira search seems to not work very well. > > On Thu, Feb 7, 2019 at 2:24 PM Kirk Lund <kl...@apache.org> wrote: > > > The UpgradeTest failures on your latest commit for this PR are > > WANRollingUpgradeNewSenderProcessOldEvent which seems to be a > reoccurrence > > of [GEODE-3967](https://issues.apache.org/jira/browse/GEODE-3967). I > > recommend having Gester take a look at that these failures. He marked > > [GEODE-3967](https://issues.apache.org/jira/browse/GEODE-3967) as > > resolved on Jan 9th. > > > > On Thu, Feb 7, 2019 at 12:37 PM Jens Deppe <jde...@pivotal.io> wrote: > > > >> No worries. I think I have a better fix now. At least the builds are > >> moving > >> again. > >> > >> On Thu, Feb 7, 2019 at 12:11 PM Kirk Lund <kl...@apache.org> wrote: > >> > >> > Sorry, go ahead and revert the commit and reopen the PR. > >> > > >> > On Thu, Feb 7, 2019 at 11:36 AM Jens Deppe <jde...@pivotal.io> wrote: > >> > > >> > > I was still working on a fix... > >> > > > >> > > On Thu, Feb 7, 2019 at 11:31 AM Kirk Lund <kl...@apache.org> wrote: > >> > > > >> > > > I merged it in. > >> > > > > >> > > > On Thu, Feb 7, 2019 at 11:28 AM Kirk Lund <kl...@apache.org> > wrote: > >> > > > > >> > > > > I think we should go ahead and merge in > >> > > > > https://github.com/apache/geode/pull/3172 since it resolves the > >> > > > > GfshConsoleModeUnitTest UnitTest failures. > >> > > > > > >> > > > > On Thu, Feb 7, 2019 at 9:57 AM Nabarun Nag <n...@pivotal.io> > >> wrote: > >> > > > > > >> > > > >> FYI, I have just merged a ci timeout fix to increase the > timeout > >> for > >> > > > >> geode-benchmarks to 4h. This does not influence any geode > >> modules. > >> > > > >> > >> > > > >> Regards > >> > > > >> Naba > >> > > > >> > >> > > > >> On Thu, Feb 7, 2019 at 9:32 AM Alexander Murmann < > >> > amurm...@apache.org > >> > > > > >> > > > >> wrote: > >> > > > >> > >> > > > >> > Hi folks, > >> > > > >> > > >> > > > >> > Our CI is very red since ~24 hours > >> > > > >> > < > >> > > > >> > > >> > > > >> > >> > > > > >> > > > >> > > >> > https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/UnitTestOpenJDK11/builds/372 > >> > > > >> > >. > >> > > > >> > It looks like a substantial new issue was introduced. > >> > > > >> > > >> > > > >> > Can we hold off on merging new changes to the develop branch > >> till > >> > > this > >> > > > >> > issue is resolved? > >> > > > >> > > >> > > > >> > Thank you all! > >> > > > >> > > >> > > > >> > >> > > > > > >> > > > > >> > > > >> > > >> > > >
