> On May 30, 2019, at 4:47 PM, Owen Nichols <onich...@pivotal.io> wrote: > > Some folks have found it really helpful to have the PR author schedule a > walk-through of the changes to give reviewers more context and explain the > thinking behind the changes. This can’t be policy unless the walkthrough is scheduled with the whole dev@geode community. You could say in your PR that a walkthrough will happen at a given time and location (online) so that interested parties could watch and ask questions. This strikes me as extremely onerous for most PRs. For large scale refactors, features, etc. maybe it makes sense, though for those a discussion thread should have happened on dev@geode first. -Jake
- [DISCUSS] require reviews before merging a PR Owen Nichols
- Re: [DISCUSS] require reviews before merging a PR Bruce Schuchardt
- Re: [DISCUSS] require reviews before merging a ... Owen Nichols
- Re: [DISCUSS] require reviews before mergin... Anthony Baker
- Re: [DISCUSS] require reviews before me... Jacob Barrett
- Re: [DISCUSS] require reviews before mergin... Jacob Barrett
- Re: [DISCUSS] require reviews before me... Dave Barnes
- Re: [DISCUSS] require reviews befo... Owen Nichols
- Re: [DISCUSS] require reviews ... Jacob Barrett
- Re: [DISCUSS] require revi... Alexander Murmann
- Re: [DISCUSS] require revi... Anthony Baker
- Re: [DISCUSS] require revi... Owen Nichols
- Re: [DISCUSS] require revi... Jinmei Liao
- Re: [DISCUSS] require revi... Nabarun Nag
- Re: [DISCUSS] require revi... Anthony Baker
- Re: [DISCUSS] require revi... Jinmei Liao