> On May 30, 2019, at 4:47 PM, Owen Nichols <onich...@pivotal.io> wrote:
> 
> Some folks have found it really helpful to have the PR author schedule a 
> walk-through of the changes to give reviewers more context and explain the 
> thinking behind the changes.

This can’t be policy unless the walkthrough is scheduled with the whole 
dev@geode community. You could say in your PR that a walkthrough will happen at 
a given time and location (online) so that interested parties could watch and 
ask questions. This strikes me as extremely onerous for most PRs. For large 
scale refactors, features, etc. maybe it makes sense, though for those a 
discussion thread should have happened on dev@geode first.

-Jake

Reply via email to