+1 to the revised approach. I think requiring at least one review is important. More eyes make for better code.
Cheers, Joris. On Mon, Oct 21, 2019 at 8:11 AM Ju@N <jujora...@gmail.com> wrote: > +10 to Naba's proposal, it seems the right thing to do and will help us to > prevent accidentally breaking *develop* while keeping focus on people > instead of processes. > I'd add, however, that the *Merge Pull Request* button should remain > disabled until *all CIs have finished*, and only enable it once the *Build, > Unit, Stress Tests and LGTM are green *(that is, force the committer to > wait at least until all CIs are done)*. *I also agree in that that we > should require *at least one* official approval. > Cheers. > -- *Joris Melchior * CF Engineering Pivotal Toronto 416 877 5427 “Programs must be written for people to read, and only incidentally for machines to execute.” – *Hal Abelson* <https://en.wikipedia.org/wiki/Hal_Abelson>
