There appears to be consensus that this is a critical fix.

The following commit has been brought into release/1.12 as the
critical fix for GEODE-7752:

git cherry-pick -x 7028f601680fee3f57cbdff63951128d7180ca13
git cherry-pick -x 9c102e4f8836ca32ad51a05bbd4d0107e8fc0343

GEODE-XXXX has been marked as 'resolved in' 1.12.

Regards
EB


On Wed, Feb 5, 2020 at 9:17 PM Udo Kohlmeyer <u...@apache.com> wrote:

> Hi there EB,
>
> fix has been merged to develop. (Everything is green now)
>
> 9c102e4f8836ca32ad51a05bbd4d0107e8fc0343
>
> Thanks
>
> --Udo
>
> 0On 2/5/20 4:34 PM, Ernest Burghardt wrote:
> > Fair enough Udo, just let us know when you have it ready.
> >
> > Thanks,
> > EB
> >
> > On Wed, Feb 5, 2020 at 4:31 PM Udo Kohlmeyer <u...@apache.com> wrote:
> >
> >> My apologies.. I had paid further attention to this, after I made
> >> changes to the assembly-context.txt file.
> >>
> >> I will revert now and then come back when it passes all test
> requirements.
> >>
> >> --Udo
> >>
> >>
> >> On 2/5/20 4:14 PM, Ernest Burghardt wrote:
> >>> Udo,
> >>> the PR has some failing tests that are in the "non-mandatory" category
> >> for
> >>> merge, TBH I'd prefer to have solid green changes being added at this
> >> point
> >>> forward...
> >>>
> >>> Thanks,
> >>> EB
> >>>
> >>> On Wed, Feb 5, 2020 at 3:01 PM Alexander Murmann <amurm...@apache.org>
> >>> wrote:
> >>>
> >>>> Udo, you say "refactor", but this sounds more like a feature or user
> >> facing
> >>>> improvement. Do you mind elaborating a little more why this should be
> in
> >>>> this release?
> >>>>
> >>>> On Wed, Feb 5, 2020 at 1:54 PM Patrick Johnson
> >> <jpatr...@vmware.com.invalid
> >>>> wrote:
> >>>>
> >>>>> +1
> >>>>>
> >>>>> On 2/5/20, 1:53 PM, "Udo Kohlmeyer" <u...@apache.com> wrote:
> >>>>>
> >>>>>       Hi there Geode dev,
> >>>>>
> >>>>>       I would like to request that GEODE-7752
> >>>>>       (7028f601680fee3f57cbdff63951128d7180ca13) gets included into
> >> 1.12.
> >>>>>       This piece of code is a refactor of work done in GEODE-7715.
> This
> >>>>>       refactor specializes Builders and simplifies Builder behavior
> for
> >>>>> better
> >>>>>       user experience.
> >>>>>
> >>>>>       --Udo
> >>>>>
> >>>>>
> >>>>>
> >>>>>
>

Reply via email to