----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35541/#review88157 -----------------------------------------------------------
Cool. I added one comment about the JDK version - it should probably be the latest java 7. dev-tools/build/Dockerfile (line 7) <https://reviews.apache.org/r/35541/#comment140567> This probably should be jdk-7u79. I think there were some issues with some of the middle versions of jdk-7, and I know at one point geode issued warning if you were using less than 72 or something like that. - Dan Smith On June 16, 2015, 11:13 p.m., jun aoki wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35541/ > ----------------------------------------------------------- > > (Updated June 16, 2015, 11:13 p.m.) > > > Review request for geode. > > > Bugs: GEODE-60 > https://issues.apache.org/jira/browse/GEODE-60 > > > Repository: geode > > > Description > ------- > > Added Dockerfile for docker to build a container which lets users to build > Geode. > > > Diffs > ----- > > README.md 8ac89a0 > dev-tools/build/Dockerfile PRE-CREATION > > Diff: https://reviews.apache.org/r/35541/diff/ > > > Testing > ------- > > Tested locally. > > > Thanks, > > jun aoki > >
